Conversation
The previous standalone "聯繫 → 聯絡" rule treated a word that the MoE concise dictionary records as valid zh-TW as a blanket cross-strait term, producing false positives on general prose such as "民間文化聯繫", "國際聯繫", and "保持聯繫". Replace it with explicit compound rules covering the UI/customer-service phrases where 聯絡 is idiomatic TW form: 聯繫我們, 聯繫方式, 聯繫資訊, 聯繫管道, 聯繫電話, 聯繫客服, 如需協助請聯繫. 聯繫歷史 → 通話記錄 is unchanged. Add scanner regression test that locks both directions of the behavior: the new compounds fire exactly once on contact-copy spans, and ordinary prose containing 聯繫 stays silent. Close #89
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous standalone "聯繫 → 聯絡" rule treated a word that the MoE concise dictionary records as valid zh-TW as a blanket cross-strait term, producing false positives on general prose such as "民間文化聯繫", "國際聯繫", and "保持聯繫".
Replace it with explicit compound rules covering the UI/customer-service phrases where 聯絡 is the idiomatic TW form: 聯繫我們, 聯繫方式, 聯繫資訊, 聯繫管道, 聯繫電話, 聯繫客服, 如需協助請聯繫.
聯繫歷史 → 通話記錄 is unchanged.
Add scanner regression test that locks both directions of the behavior: the new compounds fire exactly once on contact-copy spans, and ordinary prose containing 聯繫 stays silent.
Close #89
Summary by cubic
Narrowed cross-strait flagging for 聯繫 to only contact-copy phrases, preventing false positives in general prose. Added tests to ensure contact CTAs are flagged once and do not lower editorial confidence.
Written for commit b5432dd. Summary will update on new commits. Review in cubic