enhancement request - wrapper for sr_install_modules and sr_remove_modules

[irfanHaslanded]

Is it possible to have this functionality within sysrepo-cpp?

This is missing, and users need to either invoke sysrepocfg/sysrepoctl, or use a raw sysrepo connection and call these api and then wrap the connection into a managed Connection..

[jktjkt]

Do you feel like sending a patch?

[irfanHaslanded]

I am unable to login into CESNET gerrit, it just says 'Forbidden'.

Maybe something like below?
Connection.hpp

    void installModules(const std::vector<std::string>& schema_paths,
            const std::optional<std::string>& search_dir);

    void removeModules(const std::vector<std::string>& modules);

Connection.cpp

static std::vector<const char*> to_vec_c_str(const std::vector<std::string>& list)
{
    std::vector<const char*> native_list;
    native_list.reserve(1 + list.size());

    // iterate with reference to elements to ensure `elem.c_str()` lives as long as `list`
    // and avoid copying
    for (const auto &elem : list) {
        native_list.push_back(elem.c_str());
    }

    // sysrepo expects this array to be null terminated!
    native_list.push_back(nullptr);

    return native_list;
}

void Connection::installModules(const std::vector<std::string>& schema_paths, const std::optional<std::string>& search_dir)
{
    auto schema_paths_c = to_vec_c_str(schema_paths);
    auto res = sr_install_modules(ctx.get(), schema_paths_c.data(),
            search_dir ? search_dir->c_str() : nullptr, nullptr);

    throwIfError(res, "Couldn't install modules");
}

void Connection::removeModules(const std::vector<std::string>& modules)
{
    auto modules_c = to_vec_c_str(modules);
    auto res = sr_remove_modules(ctx.get(), modules_c.data(), 1);
    throwIfError(res, "Couldn't remove modules");
}

[rbu9fe]

I am unable to login into CESNET gerrit, it just says 'Forbidden'.

I have the same problem when I try to login with CESNET - Sign in with Github. I didn't find any documentation about how to register or where to ask what to do. Do you have any idea?

[irfanHaslanded]

Unfortunately, no.

[jktjkt]

your GitHub profile has to have a public email address, otherwise signing in doesn’t work.

[rbu9fe]

Thanks, that worked. I'm strugging with the Commit-Id hash, somehow the commit hook, that creates it, doesn't work.
I'm trying to provide a patch for this issue including the ability to provide Yang features that shall be enabled.

[rbu9fe]

Since that is my first contribution on gerrit I'm a bit stranded. I pushed my changes here but get quite some CI errors, of which at least some seem not to be related to my change. One of which was a clang-format error. So I ran clang-format explicitly but that changed parts of the files that I didn't change, so I guess the clang-format profile is not correct, or it's unused.
For the other CI-/build-errors I guess the new functions need to be covered by a unit test?
I guess I need some help here...

---

Update: I added unit tests to the best of my knowledge but as far as I can tell the CI build fails while trying to build libyang-cpp, which shouldn't be affected by my changes... Probably there was in incompatible change in libyang, which is not yet incorporated in libyang-cpp. Do we just have to wait until they're consistent again?