Skip to content

Commit b7dc12d

Browse files
johnnylinwiwynnfelixheld
authored andcommitted
mb/intel/archercity_crb: Add EWL Hob processing for MRC error
Override the weak function mainboard_ewl_check() and select OCP_EWL. Select IPMI_KCS_ROMSTAGE and IPMI_OCP for OCP IPMI commands which are needed for OCP EWL driver, but they are Meta-specific BMC commands and don't really work for AC, this change is just for a demonstration with AC. Note that FSP UPD promoteWarnings needs to be disabled so that FSP won't block and can return to coreboot for EWL processing when memory EWL type 3 error occurs. Tested=On Intel AC, connected with a faulty DIMM can see EWL type 3 error being generated and halted with coreboot log: [DEBUG] Number of EWL entries 3 [ERROR] EWL type: 3 size:32 severity level:1 [ERROR] Major Warning Code = 0x29, Minor Warning Code = 0x04, [ERROR] Major Checkpoint: 0xb7 [ERROR] Minor Checkpoint: 0x74 [ERROR] Socket 0 [ERROR] Channel 4 [ERROR] Dimm 0 [ERROR] Rank 0 [ERROR] IPMI: ipmi_get_board_config command failed (ret=3 resp=0xc1) [DEBUG] ipmi send memory training error [DEBUG] EWL type: 1 size:19 severity level:1 [DEBUG] 0x6392e968: 01 00 00 00 13 00 01 00 00 00 b7 74 0a 03 00 04 [DEBUG] 0x6392e978: 00 00 00 [DEBUG] EWL type: 1 size:19 severity level:1 [DEBUG] 0x6392e97b: 01 00 00 00 13 00 01 00 00 00 b7 74 0a 03 00 04 [DEBUG] 0x6392e98b: 00 00 01 [EMERG] Memory Training Error! Change-Id: I4602ae356aa6e55ed0611b8ac9a206db127c297c Signed-off-by: Johnny Lin <johnny_lin@wiwynn.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/75151 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
1 parent f89cd1c commit b7dc12d

2 files changed

Lines changed: 9 additions & 0 deletions

File tree

src/mainboard/intel/archercity_crb/Kconfig

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ config BOARD_SPECIFIC_OPTIONS
55
select BOARD_ROMSIZE_KB_65536
66
select CONSOLE_OVERRIDE_LOGLEVEL
77
select IPMI_KCS
8+
select IPMI_KCS_ROMSTAGE
9+
select IPMI_OCP
810
select MEMORY_MAPPED_TPM
911
select MAINBOARD_HAS_TPM2
1012
select MAINBOARD_USES_FSP2_0
@@ -13,6 +15,7 @@ config BOARD_SPECIFIC_OPTIONS
1315
select HAVE_ACPI_TABLES
1416
select MAINBOARD_USES_IFD_GBE_REGION
1517
select VPD
18+
select OCP_EWL
1619
select OCP_VPD
1720

1821
config MAINBOARD_DIR

src/mainboard/intel/archercity_crb/romstage.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,18 @@
22

33
#include <console/console.h>
44
#include <drivers/vpd/vpd.h>
5+
#include <drivers/ocp/ewl/ocp_ewl.h>
56
#include <drivers/ocp/include/vpd.h>
67
#include <soc/romstage.h>
78
#include <defs_cxl.h>
89
#include <defs_iio.h>
910
#include <sprsp_ac_iio.h>
1011

12+
void mainboard_ewl_check(void)
13+
{
14+
get_ewl();
15+
}
16+
1117
static void mainboard_config_iio(FSPM_UPD *mupd)
1218
{
1319
int port;

0 commit comments

Comments
 (0)