Fix const-correctness for pointer variables to referred strings#148
Open
kraj wants to merge 1 commit intosystemd:mainfrom
Open
Fix const-correctness for pointer variables to referred strings#148kraj wants to merge 1 commit intosystemd:mainfrom
kraj wants to merge 1 commit intosystemd:mainfrom
Conversation
Mark pointer variables 'e' as 'const char *' in config_parse_netlog_remote_address,file_in_same_dir, and socket_address_parse, since they point to memory they do not own or modify. Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
Contributor
|
We do not do sign Off. Please drop that. Also git commit --amend -m "fix: constify pointer variables referring to strings Ensure const-correctness by updating char* to const char* where strings are not modified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark pointer variables 'e' as 'const char *' in
config_parse_netlog_remote_address,file_in_same_dir, and socket_address_parse, since they point to memory they do not own or modify.
Summary
Brief description of the changes.
Fixes #(issue number)
Changes
Testing
meson test -C buildpassesChecklist