Use a vcpkg manifest for CI dependencies#923
Open
Symmetricity wants to merge 1 commit into
Open
Conversation
Move the CI vcpkg package list into vcpkg.json so dependency versions and the builtin baseline are tracked in one place. Use the manifest files for cache keys, check out the manifest baseline before install, and pass an explicit installed directory to CMake so Windows and Linux CI restore matching binary caches across reruns on the same runner image. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-generated PR.
Summary
Move the dependencies installed by vcpkg in CI into a checked-in
vcpkg.jsonmanifest.
The Windows and Ubuntu CMake jobs now install from that manifest at a pinned
vcpkg baseline. Their binary cache keys follow the manifest rather than the
whole CI workflow, while retaining the runner image and triplet in the key.
The CMake invocations use an explicit installed directory so the manifest
install and build agree on the dependency location.
This also configures Dependabot to check the vcpkg manifest and GitHub Actions
weekly. The existing version validation ensures that
vcpkg.jsonand theVERSIONfile remain in sync.This follows #915 and does not change tilemaker's runtime behavior.
Rationale
The dependency list was duplicated in two workflow commands. A manifest makes
the dependency set and vcpkg baseline reviewable in one place and lets local or
CI builds reproduce the same package graph.
Hashing the manifest for binary caches avoids rebuilding all dependencies when
an unrelated workflow step changes. Keeping the runner image and triplet in the
cache key prevents incompatible binaries from being restored across toolchain
or platform changes.
Dependabot can now propose dependency and action updates through normal pull
requests instead of requiring manual checks of package names embedded in the
workflow.
Testing
actionlint .github/workflows/ci.ymlpython3 -m json.tool vcpkg.jsonvcpkg.jsonandVERSIONboth report3.1.0x64-linuxpackage graph withvcpkg install --dry-runat the pinned baseline
git diff --check origin/master...HEAD