Implement audio and new arg to inline all media#333
Conversation
|
Welcome and thank you for your PR! Using AI for coding is fine in my opinion, as long as extensive testing is done just like you did. I think this might also be related related to #139 . I will test this for a bit to see if everything works as expected. At the very least we will have to fix the authorship info on the commits so it just shows you, not "root" and claude. |
3ba3626 to
f801ff4
Compare
|
Sure, squashed into 1 commit and replaced claude's silly history with myself. :) Not sure if it was intentional or not but this was already somewhat supported when passing the ?preview=true (except for audio) Now that I've used it a few times I think there could be use in adding a "copy hotlink" button to the page after an upload... If this gets merged I'll probably work on that next. PS: i swear claude is not root on anything that matters in my infra... it's an unprivileged LXC container (: |
f801ff4 to
7971adc
Compare
This is a super cool project! Sorry for using AI but I promise I tested the crap out of this on my homelab before opening the PR. The gist of what I think was missing was no way to just see an image/video (or listen to an audio) after doing an upload.
A new arg lets this behavior be toggled in .env and then boilerplate stuff to support audio in a similar way that images and video are handled based on if the inline arg is set or not. When the arg is set when you go to host.tld/file/hash-or-animalname instead of just downloading the file it will be displayed directly in the browser.
I'm happy to squash the commits and use my own name/email/phrasing if you don't like what claude generated (I'm not a huge fan but I must admit I didn't write it.)
I tested an image, audio, and video with the new arg set true and false and got the expected behavior on my homelab. If you want to try this on the internet with it set to true before even bothering to build it check out bin.4tw.pw