Build/Test Tools: Revert [62533], [62534].

More work is needed to ensure these changes do not introduce failures in old branches.

Reverts [62533], [62534].
See #64893.

git-svn-id: https://develop.svn.wordpress.org/trunk@62536 602fd350-edb4-49c9-b593-d223f7449a82

Author: desrosj

.github/workflows/reusable-check-built-files.yml

@@ -24,10 +24,9 @@ jobs:
   # - Builds Emoji files.
   # - Builds bundled Root Certificate files.
   # - Builds WordPress.
-  # - Checks for uncommitted changes.
-  # - Stages all uncommitted changes and adds any unversioned files.
-  # - Displays a diff of all staged changes.
-  # - Saves staged changes to a .diff file.
+  # - Checks for changes to versioned files.
+  # - Displays the result of git diff for debugging purposes.
+  # - Saves the diff to a patch file.
   # - Uploads the patch file as an artifact.
   update-built-files:
     name: Check and update built files
@@ -79,26 +78,22 @@ jobs:
       - name: Build WordPress
         run: npm run build:dev
 
-      - name: Check for uncommitted changes
+      - name: Check for changes to versioned files
         id: built-file-check
         run: |
-          if [ -z "$(git status --porcelain)" ]; then
+          if git diff --quiet; then
             echo "uncommitted_changes=false" >> "$GITHUB_OUTPUT"
           else
             echo "uncommitted_changes=true" >> "$GITHUB_OUTPUT"
           fi
 
-      - name: Stage all changes for diff generation
+      - name: Display changes to versioned files
         if: ${{ steps.built-file-check.outputs.uncommitted_changes == 'true' }}
-        run: git add -A
-
-      - name: Display all uncommitted changes
-        if: ${{ steps.built-file-check.outputs.uncommitted_changes == 'true' }}
-        run: git diff --cached
+        run: git diff
 
       - name: Save diff to a file
         if: ${{ steps.built-file-check.outputs.uncommitted_changes == 'true' }}
-        run: git diff --cached --binary > ./changes.diff
+        run: git diff > ./changes.diff
 
       # Uploads the diff file as an artifact.
       - name: Upload diff file as artifact

.github/workflows/reusable-coding-standards-javascript.yml

@@ -24,7 +24,7 @@ jobs:
   # - Logs debug information about the GitHub Action runner.
   # - Installs npm dependencies.
   # - Run the WordPress JSHint checks.
-  # - Checks for any uncommitted changes.
+  # - Ensures version-controlled files are not modified or deleted.
   jshint:
     name: JavaScript checks
     runs-on: ubuntu-24.04
@@ -57,10 +57,5 @@ jobs:
       - name: Run JSHint
         run: npm run grunt jshint
 
-      - name: Check for uncommitted changes
-        run: |
-          if [ -n "$(git status --porcelain)" ]; then
-            echo "Uncommitted changes detected:"
-            git status --porcelain
-            exit 1
-          fi
+      - name: Ensure version-controlled files are not modified or deleted
+        run: git diff --exit-code

.github/workflows/reusable-coding-standards-php.yml

@@ -37,7 +37,7 @@ jobs:
   # - Generate a report for displaying issues as pull request annotations.
   # - Runs PHPCS on the `tests` directory without (warnings included).
   # - Generate a report for displaying `test` directory issues as pull request annotations.
-  # - Checks for any uncommitted changes.
+  # - Ensures version-controlled files are not modified or deleted.
   phpcs:
     name: PHP checks
     runs-on: ubuntu-24.04
@@ -105,10 +105,5 @@ jobs:
         if: ${{ inputs.old-branch }}
         run: phpcbf
 
-      - name: Check for uncommitted changes
-        run: |
-          if [ -n "$(git status --porcelain)" ]; then
-            echo "Uncommitted changes detected:"
-            git status --porcelain
-            exit 1
-          fi
+      - name: Ensure version-controlled files are not modified during the tests
+        run: git diff --exit-code

.github/workflows/reusable-end-to-end-tests.yml

@@ -61,7 +61,7 @@ jobs:
   # - Install additional languages.
   # - Run the E2E tests.
   # - Uploads screenshots and HTML snapshots as an artifact.
-  # - Checks for any uncommitted changes.
+  # - Ensures version-controlled files are not modified or deleted.
   e2e-tests:
     name: SCRIPT_DEBUG ${{ inputs.LOCAL_SCRIPT_DEBUG && 'enabled' || 'disabled' }}
     runs-on: ubuntu-24.04
@@ -153,10 +153,5 @@ jobs:
           if-no-files-found: ignore
           include-hidden-files: true
 
-      - name: Check for uncommitted changes
-        run: |
-          if [ -n "$(git status --porcelain)" ]; then
-            echo "Uncommitted changes detected:"
-            git status --porcelain
-            exit 1
-          fi
+      - name: Ensure version-controlled files are not modified or deleted
+        run: git diff --exit-code

.github/workflows/reusable-javascript-tests.yml

@@ -25,7 +25,7 @@ jobs:
   # - Logs debug information about the GitHub Action runner.
   # - Installs npm dependencies.
   # - Run the WordPress QUnit tests.
-  # - Checks for any uncommitted changes.
+  # - Ensures version-controlled files are not modified or deleted.
   test-js:
     name: Run QUnit tests
     runs-on: ubuntu-24.04
@@ -67,10 +67,5 @@ jobs:
       - name: Run QUnit tests
         run: npm run grunt qunit:compiled
 
-      - name: Check for uncommitted changes
-        run: |
-          if [ -n "$(git status --porcelain)" ]; then
-            echo "Uncommitted changes detected:"
-            git status --porcelain
-            exit 1
-          fi
+      - name: Ensure version-controlled files are not modified or deleted
+        run: git diff --exit-code

.github/workflows/reusable-javascript-type-checking-v1.yml

@@ -23,7 +23,7 @@ jobs:
   # - Configures caching for TypeScript build info.
   # - Runs JavaScript type checking.
   # - Saves the TypeScript build info.
-  # - Checks for any uncommitted changes.
+  # - Ensures version-controlled files are not modified or deleted.
   typecheck:
     name: Run JavaScript type checking
     runs-on: ubuntu-24.04
@@ -72,10 +72,5 @@ jobs:
             *.tsbuildinfo
           key: "ts-build-info-${{ github.run_id }}"
 
-      - name: Check for uncommitted changes
-        run: |
-          if [ -n "$(git status --porcelain)" ]; then
-            echo "Uncommitted changes detected:"
-            git status --porcelain
-            exit 1
-          fi
+      - name: Ensure version-controlled files are not modified or deleted
+        run: git diff --exit-code

.github/workflows/reusable-performance-test-v2.yml

@@ -102,7 +102,7 @@ jobs:
   # - Install MU plugin.
   # - Run performance tests.
   # - Archive artifacts.
-  # - Checks for any uncommitted changes.
+  # - Ensure version-controlled files are not modified or deleted.
   performance:
     name: Test ${{ inputs.subject == 'base' && inputs.BASE_TAG || inputs.subject }}
     runs-on: ubuntu-24.04
@@ -272,10 +272,5 @@ jobs:
           if-no-files-found: error
           include-hidden-files: true
 
-      - name: Check for uncommitted changes
-        run: |
-          if [ -n "$(git status --porcelain)" ]; then
-            echo "Uncommitted changes detected:"
-            git status --porcelain
-            exit 1
-          fi
+      - name: Ensure version-controlled files are not modified or deleted
+        run: git diff --exit-code

.github/workflows/reusable-php-compatibility.yml

@@ -30,7 +30,7 @@ jobs:
   # - Make Composer packages available globally.
   # - Runs the PHP compatibility tests.
   # - Generate a report for displaying issues as pull request annotations.
-  # - Checks for any uncommitted changes.
+  # - Ensures version-controlled files are not modified or deleted.
   php-compatibility:
     name: Run compatibility checks
     runs-on: ubuntu-24.04
@@ -86,10 +86,5 @@ jobs:
         if: ${{ always() && steps.phpcs.outcome == 'failure' }}
         run: cs2pr ./.cache/phpcs-compat-report.xml
 
-      - name: Check for uncommitted changes
-        run: |
-          if [ -n "$(git status --porcelain)" ]; then
-            echo "Uncommitted changes detected:"
-            git status --porcelain
-            exit 1
-          fi
+      - name: Ensure version-controlled files are not modified or deleted
+        run: git diff --exit-code

.github/workflows/reusable-phpstan-static-analysis-v1.yml

@@ -33,7 +33,7 @@ jobs:
   # - Configures caching for PHPStan static analysis scans.
   # - Runs PHPStan static analysis (with Pull Request annotations).
   # - Saves the PHPStan result cache.
-  # - Checks for any uncommitted changes.
+  # - Ensures version-controlled files are not modified or deleted.
   phpstan:
     name: Run PHP static analysis
     runs-on: ubuntu-24.04
@@ -102,10 +102,5 @@ jobs:
           path: .cache
           key: "phpstan-result-cache-${{ github.run_id }}"
 
-      - name: Check for uncommitted changes
-        run: |
-          if [ -n "$(git status --porcelain)" ]; then
-            echo "Uncommitted changes detected:"
-            git status --porcelain
-            exit 1
-          fi
+      - name: Ensure version-controlled files are not modified or deleted
+        run: git diff --exit-code

.github/workflows/reusable-phpunit-tests-v2.yml

@@ -84,7 +84,7 @@ jobs:
   # - Logs debug information from inside the WordPress Docker container.
   # - Install WordPress within the Docker container.
   # - Run the PHPUnit tests.
-  # - Checks for any uncommitted changes.
+  # - Ensures version-controlled files are not modified or deleted.
   test-php:
     name: PHP ${{ inputs.php }} / ${{ inputs.multisite && ' Multisite' || 'Single Site' }}${{ inputs.split_slow && ' slow tests' || '' }}${{ inputs.memcached && ' with memcached' || '' }}
     runs-on: ${{ inputs.os }}
@@ -208,5 +208,5 @@ jobs:
         if: ${{ ! inputs.split_slow }}
         run: LOCAL_PHP_XDEBUG=true npm run "test:${PHPUNIT_SCRIPT}" -- -v --group xdebug --exclude-group __fakegroup__
 
-      - name: Check for uncommitted changes
+      - name: Ensure version-controlled files are not modified or deleted
         run: git diff --exit-code