Custom Error Handling Prototype#145
Open
ianjosephwilson wants to merge 65 commits into
Open
Conversation
… instead of self-closing.
… positions consistent across parsings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SourceTrackerHTMLParser.getpos()could be reconciled with the current string/interpolation index of theTemplatewhile feeding parts but there does not seem to be an easy way to do that.ParserPositionTranslator,LineLocationandPartLocationparser_pos: LineLocationand a current positionpos: MutableLineLocation, and walkposthrough theTemplateparts with the embedded placeholders looping viaindexandoffsetuntilparser_pos == posandsource_pos = PartLocation(index, offset).SourceReaderSourceTrackerwith the appropriate template to extract the source with the interpolation expressions (when already raising errors) as well as translatePartLocationtoLineLocation(but dependent on the string representations of the interpolations).ParsingError(s)ProcessingError(s)TNodetemplateandTTree(contains the templateTNode root) to the exceptionchainthem withraise ProcessingError() from eTemplateProcessor.process()we should have a singleProcessingErrorthat has a stack of error states that go down until we reach the lowest levelTemplatewhere an error first occurred so we could print something LIKE this (TBD):ProcessingErrororParsingError.