Skip to content

Support optional parameters for login #175

@tototoshi

Description

@tototoshi

Currently, OAuth2Controller#login and OAuth2Controller#link doesn't support optional parameters.

// TODO scope is optional in some services
// TODO some services have more optional parameter
def login(scope: String) = AsyncStack(ExecutionContextKey -> OAuthExecutionContext) { implicit request =>

  // TODO scope is optional in some services
  // TODO some services have more optional parameter
  def login(scope: String) = AsyncStack(ExecutionContextKey -> OAuthExecutionContext) { implicit request =>

To solve this problem, I think some changes (including API changes) is required. My idea is:

  • Remove the scope argument because scope is optional
  • OAuth2Authenticator#getAuthorizationUrl should take request instead of scope

The task of login is only redirecting to authorization url, so it is enough only to change the API of OAuth2Authenticator#getAuthorizationUrl. is this correct?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions