Add support for executing external command on detected fileName string#11
Open
naorunaoru wants to merge 2 commits into
Open
Add support for executing external command on detected fileName string#11naorunaoru wants to merge 2 commits into
naorunaoru wants to merge 2 commits into
Conversation
Author
|
I can't figure out what caused tests to fail. Can anyone help me please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature is needed to support various external resolvers.
For instance, our client-side stack supports requiring files by namespace, e.g.
require('app:ui.field.input’). This syntax is specific to our project with paths defined in a project config file. We have a command-line tool which can resolve those namespaced paths to real paths and to use it I needed to add this custom functionality in open-this.