style: re-sync test scaffolding to canonical template (post-#36) (#55)

* style: align test scaffolding with canonical PSMTplt

Apply the three style rules from PowerShellModuleTemplate#23 to the
Help/Meta/MetaFixers test files this repo inherited from the template:

- Named parameters on multi-arg cmdlet calls (Split-Path, Join-Path,
  Test-Path, Get-Module, Get-Content, Select-String, Get-TextFilesList,
  Test-FileUnicode)
- ValidateNotNull / ValidateNotNullOrEmpty validators on mandatory
  param entries in tests/MetaFixers.psm1
- Test-FileUnicode call inside Get-UnicodeFilesList now uses named
  -FileInfo parameter

Also fixes a stale $parameterNames reference in the last Context block
of Help.tests.ps1 (should be $commandParameterNames). Bug bundled in
per the cross-repo audit.

tests/Manifest.tests.ps1 is the older Module Dependency variant
(no Test-VersionConstraint helper, -Child typo on Join-Path) and is
deferred to a separate uplift PR.

Behavior is unchanged.

* style: re-sync test scaffolding to post-#36 canonical template

PowerShellModuleTemplate#36 (merged after this branch opened) scoped the
named-parameter rule: name parameters only on calls passing two or more
arguments (a trailing switch counts); single-argument calls stay
positional. #36 explicitly calls out this PR as a consumer to re-sync.

Revert the over-naming on single-argument calls so these files match the
current canonical template:

- Help.tests.ps1: Import-PowerShellDataFile, Test-Path, Import-Module,
  Get-Help, and global:FilterOutCommonParameters back to positional.
  Split-Path -Path .. -Parent and Join-Path -Path .. -ChildPath stay
  named (two-plus arguments).
- Meta.tests.ps1: Import-Module back to positional; Get-Content -Path
  .. -Raw stays named (switch counts as an argument).
- MetaFixers.psm1: Test-FileUnicode call in Get-UnicodeFilesList back to
  positional.

Kept: the four ValidateNotNull/ValidateNotNullOrEmpty validators (added
by template #23, not reverted by #36) and the comment-based-help
.EXAMPLE calls (#36 leaves these named for teaching clarity).

MetaFixers.psm1 and Meta.tests.ps1 are now byte-identical to upstream;
Help.tests.ps1 differs only in this repo's local divergences (the
Set-BuildEnvironment bootstrap and comment-based help). Behavior
unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* style: replace em-dashes with hyphens in Help.tests.ps1 comment

The two em-dashes (U+2014) in the local Set-BuildEnvironment comment
block were the sole non-ASCII content in the file, tripping
PSScriptAnalyzer's PSUseBOMForUnicodeEncodedFile rule. Replace them with
ASCII hyphens so the file is pure ASCII (matching the canonical template
files) and PSSA is clean without adding a BOM or a suppression.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: tablackburn

tests/Help.tests.ps1

@@ -70,10 +70,10 @@ BeforeDiscovery {
     build the module. #>
     if ($null -eq $Env:BHBuildOutput) {
         # Populate BuildHelpers env vars so build.psake.ps1's properties block has
-        # the values it needs (BHPSModuleManifest, BHProjectName) — when running
+        # the values it needs (BHPSModuleManifest, BHProjectName) - when running
         # via ./build.ps1 this happens before psake; running tests in isolation
         # bypasses that, so we do it here.
-        Set-BuildEnvironment -Path (Split-Path -Parent $PSScriptRoot) -Force
+        Set-BuildEnvironment -Path (Split-Path -Path $PSScriptRoot -Parent) -Force
         $buildFilePath = Join-Path -Path $PSScriptRoot -ChildPath '..\build.psake.ps1'
         $invokePsakeParameters = @{
             TaskList  = 'Build'
@@ -83,10 +83,10 @@ BeforeDiscovery {
     }
 
     # PowerShellBuild outputs to Output/<ModuleName>/<Version>/, override BHBuildOutput
-    $projectRoot = Split-Path -Parent $PSScriptRoot
-    $sourceManifest = Join-Path $projectRoot "$Env:BHProjectName/$Env:BHProjectName.psd1"
-    $moduleVersion = (Import-PowerShellDataFile -Path $sourceManifest).ModuleVersion
-    $Env:BHBuildOutput = Join-Path $projectRoot "Output/$Env:BHProjectName/$moduleVersion"
+    $projectRoot = Split-Path -Path $PSScriptRoot -Parent
+    $sourceManifest = Join-Path -Path $projectRoot -ChildPath "$Env:BHProjectName/$Env:BHProjectName.psd1"
+    $moduleVersion = (Import-PowerShellDataFile $sourceManifest).ModuleVersion
+    $Env:BHBuildOutput = Join-Path -Path $projectRoot -ChildPath "Output/$Env:BHProjectName/$moduleVersion"
 
     # Define the path to the module manifest
     $moduleManifestFilename = $Env:BHProjectName + '.psd1'
@@ -105,7 +105,7 @@ BeforeDiscovery {
 
     # Remove all versions of the module from the session. Pester can't handle multiple versions.
     Get-Module $Env:BHProjectName | Remove-Module -Force -ErrorAction 'Ignore'
-    Import-Module -Name $moduleManifestPath -Verbose:$false -ErrorAction 'Stop'
+    Import-Module $moduleManifestPath -Verbose:$false -ErrorAction 'Stop'
 
     # Get module commands
     $getCommandParameters = @{
@@ -128,10 +128,10 @@ BeforeAll {
     build the module. #>
     if ($null -eq $Env:BHBuildOutput) {
         # Populate BuildHelpers env vars so build.psake.ps1's properties block has
-        # the values it needs (BHPSModuleManifest, BHProjectName) — when running
+        # the values it needs (BHPSModuleManifest, BHProjectName) - when running
         # via ./build.ps1 this happens before psake; running tests in isolation
         # bypasses that, so we do it here.
-        Set-BuildEnvironment -Path (Split-Path -Parent $PSScriptRoot) -Force
+        Set-BuildEnvironment -Path (Split-Path -Path $PSScriptRoot -Parent) -Force
         $buildFilePath = Join-Path -Path $PSScriptRoot -ChildPath '..\build.psake.ps1'
         $invokePsakeParameters = @{
             TaskList  = 'Build'
@@ -149,10 +149,10 @@ Describe "Test help for <_.Name>" -ForEach $commands {
         # -ForEach, which Pester evaluates during discovery (before BeforeAll runs).
         $command               = $_
         $commandName           = $command.Name
-        $commandHelp           = Get-Help -Name $command.Name -ErrorAction 'SilentlyContinue'
-        $commandParameters     = global:FilterOutCommonParameters -Parameters $command.ParameterSets.Parameters
+        $commandHelp           = Get-Help $command.Name -ErrorAction 'SilentlyContinue'
+        $commandParameters     = global:FilterOutCommonParameters $command.ParameterSets.Parameters
         $commandParameterNames = $commandParameters.Name
-        $helpParameters        = global:FilterOutCommonParameters -Parameters $commandHelp.Parameters.Parameter
+        $helpParameters        = global:FilterOutCommonParameters $commandHelp.Parameters.Parameter
         $helpParameterNames    = $helpParameters.Name
         $helpLinks             = $commandHelp.relatedLinks.navigationLink.uri | Where-Object { $_ -match '^https?://' }
     }
@@ -161,10 +161,10 @@ Describe "Test help for <_.Name>" -ForEach $commands {
         # These variables are needed in both discovery and test phases so we need to duplicate them here
         $command                = $_
         $commandName            = $_.Name
-        $commandHelp            = Get-Help -Name $command.Name -ErrorAction 'SilentlyContinue'
-        $commandParameters      = global:FilterOutCommonParameters -Parameters $command.ParameterSets.Parameters
+        $commandHelp            = Get-Help $command.Name -ErrorAction 'SilentlyContinue'
+        $commandParameters      = global:FilterOutCommonParameters $command.ParameterSets.Parameters
         $commandParameterNames  = $commandParameters.Name
-        $helpParameters         = global:FilterOutCommonParameters -Parameters $commandHelp.Parameters.Parameter
+        $helpParameters         = global:FilterOutCommonParameters $commandHelp.Parameters.Parameter
         $helpParameterNames     = $helpParameters.Name
     }
 

tests/Meta.tests.ps1

@@ -2,7 +2,7 @@ BeforeAll {
     Set-StrictMode -Version 'Latest'
 
     # Make sure MetaFixers.psm1 is loaded - it contains Get-TextFilesList
-    Import-Module -Name (Join-Path -Path $PSScriptRoot -ChildPath 'MetaFixers.psm1') -Verbose:$false -Force
+    Import-Module (Join-Path -Path $PSScriptRoot -ChildPath 'MetaFixers.psm1') -Verbose:$false -Force
 
     $projectRoot = $Env:BHProjectPath
     if (-not $projectRoot) {
@@ -24,7 +24,7 @@ BeforeAll {
         $unicodeFilesCount | Should -Be 0
 
         $fileName = $textFile.FullName
-        (Get-Content $fileName -Raw) | Select-String "`t" | Foreach-Object {
+        (Get-Content -Path $fileName -Raw) | Select-String "`t" | Foreach-Object {
             Write-Warning (
                 "There are tabs in $fileName." +
                 ' Use Fixer "Get-TextFilesList `$pwd | ConvertTo-SpaceIndentation".'

tests/MetaFixers.psm1

@@ -27,6 +27,7 @@ function ConvertTo-UTF8 {
     [OutputType([void])]
     param(
         [Parameter(Mandatory = $true, ValueFromPipeline = $true)]
+        [ValidateNotNull()]
         [System.IO.FileInfo]$FileInfo
     )
 
@@ -56,6 +57,7 @@ function ConvertTo-SpaceIndentation {
     [OutputType([void])]
     param(
         [Parameter(Mandatory = $true, ValueFromPipeline = $true)]
+        [ValidateNotNull()]
         [System.IO.FileInfo]$FileInfo
     )
 
@@ -85,6 +87,7 @@ function Get-TextFilesList {
     [OutputType([System.IO.FileInfo])]
     param(
         [Parameter(Mandatory = $true, ValueFromPipeline = $true)]
+        [ValidateNotNullOrEmpty()]
         [string]$Root
     )
 
@@ -159,6 +162,7 @@ function Get-UnicodeFilesList {
     [OutputType([System.IO.FileInfo])]
     param(
         [Parameter(Mandatory = $true)]
+        [ValidateNotNullOrEmpty()]
         [string]$Root
     )