fix: Validate PSScriptAnalyzer availability and harden WhatIf tests (#36)

* fix: Skip PSScriptAnalyzer install on cache hit

The lint job was unconditionally running Install-Module even when the
module was already restored from cache. This caused Install-Module
-Force to conflict with the already-loaded cached module, triggering a
NullReferenceException in PSScriptAnalyzer.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: Validate PSScriptAnalyzer availability and harden WhatIf tests

Replace GitHub Actions cache-hit conditional with runtime module
availability check to handle corrupt or empty caches gracefully.
Refactor WhatIf integration tests to assert on specific collection
titles and IDs instead of counts to prevent flaky failures from
concurrent server state changes.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: Address review feedback from Copilot

Remove unused cache step ID, fix misleading log message, and use
GUID instead of Get-Random for WhatIf test collection title.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: Validate PSScriptAnalyzer importability beyond module discovery

Strengthen the cache validation by attempting a full Import-Module and
verifying Invoke-ScriptAnalyzer is available, rather than relying solely
on Get-Module -ListAvailable which only checks file presence.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: Create dedicated collection for Remove WhatIf test

The test was picking an arbitrary existing collection which could be
deleted by concurrent test cleanup. Create a dedicated collection,
verify it survives the WhatIf, then clean it up in a finally block.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: tablackburn

.github/workflows/CI.yaml

@@ -30,8 +30,24 @@ jobs:
         if: steps.cache-lint-modules.outputs.cache-hit != 'true'
         shell: pwsh
         run: |
-          Set-PSRepository -Name PSGallery -InstallationPolicy Trusted
-          Install-Module -Name PSScriptAnalyzer -Force -Scope CurrentUser
+          $moduleFound = Get-Module -ListAvailable -Name PSScriptAnalyzer
+          if ($moduleFound) {
+            try {
+              Import-Module PSScriptAnalyzer -Force -ErrorAction Stop
+              Get-Command Invoke-ScriptAnalyzer -ErrorAction Stop | Out-Null
+              Write-Host 'PSScriptAnalyzer already available'
+            }
+            catch {
+              Write-Host 'PSScriptAnalyzer cache appears invalid; reinstalling...'
+              Set-PSRepository -Name PSGallery -InstallationPolicy Trusted
+              Install-Module -Name PSScriptAnalyzer -Force -Scope CurrentUser
+            }
+          }
+          else {
+            Write-Host 'Installing PSScriptAnalyzer...'
+            Set-PSRepository -Name PSGallery -InstallationPolicy Trusted
+            Install-Module -Name PSScriptAnalyzer -Force -Scope CurrentUser
+          }
 
       - name: Run PSScriptAnalyzer
         shell: pwsh

tests/Integration/Public/Collection.Integration.tests.ps1

@@ -415,32 +415,33 @@ Describe 'Collection WhatIf Integration Tests' -Skip:(-not $script:integrationEn
                 return
             }
 
-            $countBefore = (Get-PatCollection -LibraryId $script:testLibrary.key).Count
+            $whatIfTitle = "WhatIf-Test-Collection-$([Guid]::NewGuid())"
             $ratingKey = [int]$script:testMediaItem.ratingKey
 
-            New-PatCollection -Title 'WhatIf-Test-Collection' -LibraryId $script:testLibrary.key -RatingKey $ratingKey -WhatIf
+            New-PatCollection -Title $whatIfTitle -LibraryId $script:testLibrary.key -RatingKey $ratingKey -WhatIf
 
-            $countAfter = (Get-PatCollection -LibraryId $script:testLibrary.key).Count
-            $countAfter | Should -Be $countBefore
+            $collections = Get-PatCollection -LibraryId $script:testLibrary.key
+            $collections.Title | Should -Not -Contain $whatIfTitle
         }
 
         It 'Remove-PatCollection WhatIf does not delete collection' {
-            if (-not $script:testLibrary) {
-                Set-ItResult -Skipped -Because 'No library available for testing'
+            if (-not $script:testLibrary -or -not $script:testMediaItem) {
+                Set-ItResult -Skipped -Because 'No library or media item available for testing'
                 return
             }
 
-            $collections = Get-PatCollection -LibraryId $script:testLibrary.key
-            if ($collections) {
-                $countBefore = $collections.Count
+            $whatIfRemoveTitle = "WhatIf-Remove-Test-$([Guid]::NewGuid())"
+            $ratingKey = [int]$script:testMediaItem.ratingKey
+            $created = New-PatCollection -Title $whatIfRemoveTitle -LibraryId $script:testLibrary.key -RatingKey $ratingKey -PassThru
 
-                Remove-PatCollection -CollectionId $collections[0].CollectionId -WhatIf
+            try {
+                Remove-PatCollection -CollectionId $created.CollectionId -WhatIf
 
-                $countAfter = (Get-PatCollection -LibraryId $script:testLibrary.key).Count
-                $countAfter | Should -Be $countBefore
+                $collectionsAfter = Get-PatCollection -LibraryId $script:testLibrary.key
+                $collectionsAfter.CollectionId | Should -Contain $created.CollectionId
             }
-            else {
-                Set-ItResult -Skipped -Because 'No collections exist to test WhatIf'
+            finally {
+                Remove-PatCollection -CollectionId $created.CollectionId -Confirm:$false -ErrorAction SilentlyContinue
             }
         }
     }