fix(review): address PR #16 inline findings

- ci: hashFiles() is not allowed in jobs.<job_id>.if (actionlint and the
  GitHub Actions docs both flag it). Replace the job-level guard with a
  Detect template state step that writes is_template to $GITHUB_OUTPUT,
  then gate downstream steps on that output. CI.yaml guards Cache,
  Build/Test, and the upload steps; PublishModuleToPowerShellGallery.yaml
  guards Get Module Version and Check if Release Exists, with the
  remaining publish steps cascading via their existing dependencies on
  steps.check_release.outputs.exists.
- tests: [bigint] is a PS 7+ accelerator only; Windows PowerShell 5.1
  needs the full type. Spell it [System.Numerics.BigInteger] in
  Compare-SemVerPrerelease so the SemVer numeric-identifier comparison
  works on the 5.1 runner.
- init: switch the two hardcoded forward-slash test paths to Join-Path
  for consistency with the rest of Initialize-Template.ps1.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: tablackburn

.github/workflows/CI.yaml

@@ -56,21 +56,34 @@ jobs:
   unit-tests:
     name: Unit Tests (${{ matrix.os }})
     runs-on: ${{ matrix.os }}
-    # Skip on the un-initialized template — Build's GENERATEMARKDOWN task
-    # can't import the manifest while {{GUID}} is still a literal placeholder.
-    # Marker: CHANGELOG.template.md exists only pre-init; Initialize-Template.ps1
-    # moves it onto CHANGELOG.md during init, so downstream repos run the full
-    # job. Path has no placeholder token, so init's substitution loop leaves it
-    # intact in this file.
-    if: hashFiles('CHANGELOG.template.md') == ''
     strategy:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, windows-latest, macOS-latest]
     steps:
       - uses: actions/checkout@v6
 
+      # Skip subsequent steps on the un-initialized template — Build's
+      # GENERATEMARKDOWN task can't import the manifest while {{GUID}} is still
+      # a literal placeholder. Marker: CHANGELOG.template.md exists only
+      # pre-init; Initialize-Template.ps1 moves it onto CHANGELOG.md during
+      # init, so downstream repos run the full job. The marker path contains
+      # no placeholder token, so init's substitution loop leaves this guard
+      # intact when the workflow is copied into a new module.
+      # hashFiles() is not allowed in jobs.<job_id>.if, so we evaluate it in a
+      # step and gate downstream steps on the resulting output.
+      - name: Detect template state
+        id: template_guard
+        shell: bash
+        run: |
+          if [ -f CHANGELOG.template.md ]; then
+            echo "is_template=true" >> "$GITHUB_OUTPUT"
+          else
+            echo "is_template=false" >> "$GITHUB_OUTPUT"
+          fi
+
       - name: Cache PowerShell modules
+        if: steps.template_guard.outputs.is_template == 'false'
         uses: actions/cache@v5
         with:
           path: |
@@ -81,23 +94,24 @@ jobs:
             ${{ runner.os }}-psmodules-
 
       - name: Build and Test
+        if: steps.template_guard.outputs.is_template == 'false'
         shell: pwsh
         run: |
           New-Item -Path out -ItemType Directory -Force | Out-Null
           ./build.ps1 -Task Build,Test -Bootstrap
 
       - name: Upload Coverage to Codecov
+        if: success() && steps.template_guard.outputs.is_template == 'false'
         uses: codecov/codecov-action@v6
-        if: success()
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           files: out/codeCoverage.xml
           flags: ${{ matrix.os }}
           fail_ci_if_error: false
 
       - name: Upload Test Results
+        if: always() && steps.template_guard.outputs.is_template == 'false'
         uses: actions/upload-artifact@v7
-        if: always()
         with:
           name: test-results-${{ matrix.os }}
           path: out/

.github/workflows/PublishModuleToPowerShellGallery.yaml

@@ -15,17 +15,32 @@ jobs:
   publish:
     name: Publish Module
     runs-on: ubuntu-latest
-    # Never publish the un-initialized template — the .psd1 still has
-    # {{ModuleName}} and {{GUID}} placeholders. Same marker as CI.yaml.
-    if: hashFiles('CHANGELOG.template.md') == ''
     steps:
       - name: Checkout
         uses: actions/checkout@v6
         with:
           fetch-depth: 0
 
+      # Never publish the un-initialized template — the .psd1 still has
+      # {{ModuleName}} and {{GUID}} placeholders. Same marker as CI.yaml:
+      # CHANGELOG.template.md exists only pre-init. hashFiles() is not allowed
+      # in jobs.<job_id>.if, so we evaluate it in a step and gate the
+      # version-detection and release-check steps on the resulting output;
+      # everything downstream cascades on those steps' outputs and skips
+      # naturally when they don't run.
+      - name: Detect template state
+        id: template_guard
+        shell: bash
+        run: |
+          if [ -f CHANGELOG.template.md ]; then
+            echo "is_template=true" >> "$GITHUB_OUTPUT"
+          else
+            echo "is_template=false" >> "$GITHUB_OUTPUT"
+          fi
+
       - name: Get Module Version
         id: version
+        if: steps.template_guard.outputs.is_template == 'false'
         shell: pwsh
         run: |
           $manifest = Import-PowerShellDataFile -Path ./{{ModuleName}}/{{ModuleName}}.psd1
@@ -35,6 +50,7 @@ jobs:
 
       - name: Check if Release Exists
         id: check_release
+        if: steps.template_guard.outputs.is_template == 'false'
         shell: bash
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Initialize-Template.ps1

@@ -242,8 +242,9 @@ if (Test-Path -Path $templateModuleFolder) {
     # Rename example function files
     $publicFolder = Join-Path -Path $moduleFolder -ChildPath 'Public'
     $privateFolder = Join-Path -Path $moduleFolder -ChildPath 'Private'
-    $testPublicFolder = Join-Path -Path $PSScriptRoot -ChildPath 'tests/Unit/Public'
-    $testPrivateFolder = Join-Path -Path $PSScriptRoot -ChildPath 'tests/Unit/Private'
+    $testUnitFolder = Join-Path -Path (Join-Path -Path $PSScriptRoot -ChildPath 'tests') -ChildPath 'Unit'
+    $testPublicFolder = Join-Path -Path $testUnitFolder -ChildPath 'Public'
+    $testPrivateFolder = Join-Path -Path $testUnitFolder -ChildPath 'Private'
 
     $foldersToCheck = @($publicFolder, $privateFolder, $testPublicFolder, $testPrivateFolder)
 

tests/ManifestHelpers.psm1

@@ -123,9 +123,10 @@ function Compare-SemVerPrerelease {
 
         if ($firstIsNumeric -and $secondIsNumeric) {
             # SemVer 2.0.0 permits arbitrarily large numeric identifiers — use BigInteger
-            # rather than [long] to avoid overflow.
-            $firstNum = [bigint]$firstId
-            $secondNum = [bigint]$secondId
+            # rather than [long] to avoid overflow. [bigint] is a PS 7+ accelerator only,
+            # so spell out the full type for Windows PowerShell 5.1 compatibility.
+            $firstNum = [System.Numerics.BigInteger]$firstId
+            $secondNum = [System.Numerics.BigInteger]$secondId
 
             if ($firstNum -lt $secondNum) {
                 return -1