ci(release): allow PSGallery publish to recover when the GitHub release already exists (#20)

* ci(release): allow PSGallery publish to recover when the release already exists

Propagates PowerShellModuleTemplate#33. Publishing was gated on 'GitHub release
does not exist', so a release-created-but-publish-failed run could never recover.
Regate: PSGallery check runs unconditionally; Bootstrap runs if a release or a
publish is needed; Publish is gated only on the PSGallery check; Create Release
unchanged. Flagged by CodeRabbit + Copilot during the YTMP rollout.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* ci(release): fail the PSGallery check on a query error instead of assuming not-published

Addresses #20 review (Copilot): now that Publish is gated only on this check,
Find-Module -ErrorAction SilentlyContinue returning $null was treated as
'not on gallery' for BOTH a genuine miss and a transient query failure. Capture
-ErrorVariable: publish only on a clean miss (Find-Module records no error for a
genuine not-found, verified); on a recorded error, throw so the run is retryable.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: tablackburn

.github/workflows/PublishModuleToPowerShellGallery.yaml

@@ -47,23 +47,31 @@ jobs:
 
       - name: Check if PSGallery Version Exists
         id: check_psgallery
-        if: steps.check_release.outputs.exists == 'false'
+        # Runs unconditionally so a release that was created but never published can
+        # still be recovered (see Publish gating below).
         shell: pwsh
         env:
           VERSION: ${{ steps.version.outputs.version }}
         run: |
           $version = $env:VERSION
-          $published = Find-Module -Name ReScenePS -RequiredVersion $version -Repository PSGallery -ErrorAction SilentlyContinue
+          $findError = $null
+          $published = Find-Module -Name ReScenePS -RequiredVersion $version -Repository PSGallery -ErrorAction SilentlyContinue -ErrorVariable findError
           if ($published) {
             Write-Host "PSGallery version $version already exists"
             "exists=true" | Out-File -FilePath $env:GITHUB_OUTPUT -Append
+          } elseif ($findError) {
+            # Find-Module records no error when the version simply isn't on the gallery,
+            # so a recorded error means the query itself failed (transient/network). Don't
+            # treat that as "not published" (publishing is now gated only on this check) —
+            # fail so the run is visibly retryable instead of attempting a blind publish.
+            throw "PowerShell Gallery query failed for version ${version}: $($findError[0].Exception.Message)"
           } else {
             Write-Host "PSGallery version $version not found - will publish"
             "exists=false" | Out-File -FilePath $env:GITHUB_OUTPUT -Append
           }
 
       - name: Bootstrap
-        if: steps.check_release.outputs.exists == 'false'
+        if: steps.check_release.outputs.exists == 'false' || steps.check_psgallery.outputs.exists == 'false'
         shell: pwsh
         run: ./build.ps1 -Task Init -Bootstrap
 
@@ -124,7 +132,7 @@ jobs:
           }
 
       - name: Publish to PSGallery
-        if: steps.check_release.outputs.exists == 'false' && steps.check_psgallery.outputs.exists == 'false'
+        if: steps.check_psgallery.outputs.exists == 'false'
         shell: pwsh
         env:
           PSGALLERY_API_KEY: ${{ secrets.PSGALLERY_API_KEY }}