Adding support for args in publish and export commands#356
Merged
Conversation
jacalata
approved these changes
Apr 8, 2025
Contributor
jacalata
left a comment
There was a problem hiding this comment.
Probably want a test showing that the language parameter gets through to the request.
Could also move the language code into a helper method - create an apply_csv_options method, and call it from that and the equivalent apply_png_options etc.
@staticmethod
def apply_csv_options(logger, request_options: TSC.PDFRequestOptions, args):
DatasourcesAndWorkbooks.apply_locale_options(logger, request_options, args)
jacalata
pushed a commit
that referenced
this pull request
Aug 8, 2025
* Adding replace & thumbnail options to publish command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for
--replaceto publish command--thumbnail-username&--thumbnail-groupoptions to publish command--languageoption in export commands