Skip to content

Adding support for args in publish and export commands#356

Merged
renoyjohnm merged 5 commits into
developmentfrom
feat/parity
Apr 8, 2025
Merged

Adding support for args in publish and export commands#356
renoyjohnm merged 5 commits into
developmentfrom
feat/parity

Conversation

@renoyjohnm
Copy link
Copy Markdown
Collaborator

Adding support for

  • --replace to publish command
  • --thumbnail-username & --thumbnail-group options to publish command
  • --language option in export commands

@renoyjohnm renoyjohnm requested a review from jacalata April 8, 2025 00:10
Copy link
Copy Markdown
Contributor

@jacalata jacalata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want a test showing that the language parameter gets through to the request.

Could also move the language code into a helper method - create an apply_csv_options method, and call it from that and the equivalent apply_png_options etc.

@staticmethod
def apply_csv_options(logger, request_options: TSC.PDFRequestOptions, args):
    DatasourcesAndWorkbooks.apply_locale_options(logger, request_options, args)

@renoyjohnm renoyjohnm merged commit 9b227d4 into development Apr 8, 2025
19 checks passed
jacalata pushed a commit that referenced this pull request Aug 8, 2025
* Adding replace & thumbnail options to publish command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants