@W-22354451: make resource access checking cache-safe for per-site and per-session tool scopes#337
Open
mattcfilbert wants to merge 2 commits intomainfrom
Open
@W-22354451: make resource access checking cache-safe for per-site and per-session tool scopes#337mattcfilbert wants to merge 2 commits intomainfrom
mattcfilbert wants to merge 2 commits intomainfrom
Conversation
…d per-session tool scopes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hardened
resourceAccessCheckercaching to prevent scope leakage across tenants/sites/sessions by making cache use conditional on effective bounded context. Cache lookups/writes now occur only in public checker methods after bounded context resolution, and are skipped whenever any bounded-context field is active (non-null), including empty sets. Added/updated tests to verify cross-scope isolation and preserved unscoped caching behavior.Motivation and Context
Resource access decisions were previously cached by resource LUID in a way that could allow decisions from one scope to be reused in another scope. That is unsafe for hosted multi-tenant and per-session/dynamic scoping. This change ensures scoped decisions are always evaluated independently and cannot contaminate other scope contexts.
Type of Change
How Has This Been Tested?
Executed:
npx vitest run src/tools/resourceAccessChecker.test.tsnpm testnpx tsc --noEmitnpm run lintCoverage added/updated in
src/tools/resourceAccessChecker.test.tsincludes:Related Issues
Checklist
npm run version. For example,use
npm run version:patchfor a patch version bump.environment variable or changing its default value.
Contributor Agreement
By submitting this pull request, I confirm that:
its Contribution Checklist.