fix: preserve anyOf nullable schemas without injecting type field#264
Open
Br1an67 wants to merge 1 commit intotadata-org:mainfrom
Open
fix: preserve anyOf nullable schemas without injecting type field#264Br1an67 wants to merge 1 commit intotadata-org:mainfrom
Br1an67 wants to merge 1 commit intotadata-org:mainfrom
Conversation
convert_openapi_to_mcp_tools added a top-level 'type' field to parameter schemas that already had 'anyOf' with a null variant. This broke nullable validation because JSON Schema treats 'type' and 'anyOf' as independent constraints that must all be satisfied. Skip the type injection when 'anyOf' is already present in the property schema, for path, query, and body parameters. Closes tadata-org#246
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
convert_openapi_to_mcp_toolsadded a top-leveltypefield to parameter schemas that already hadanyOfwith a null variant (e.g.Optional[str]→anyOf: [{type: string}, {type: null}]). This broke nullable validation because JSON Schema treatstypeandanyOfas independent constraints — addingtype: stringalongsideanyOfmeantnullvalues were rejected.Changes
Skip the
typeinjection whenanyOfis already present in the property schema, for path, query, and body parameters.Files changed:
fastapi_mcp/openapi/convert.py— guard type injection withand "anyOf" not in properties[param_name]tests/test_openapi_conversion.py— addedtest_nullable_anyof_schema_preservedand updated existing assertionsCloses #246