fix: pass description as keyword argument in Server initialization#282
Open
vincent067 wants to merge 1 commit intotadata-org:mainfrom
Open
fix: pass description as keyword argument in Server initialization#282vincent067 wants to merge 1 commit intotadata-org:mainfrom
vincent067 wants to merge 1 commit intotadata-org:mainfrom
Conversation
The Server constructor signature is: def __init__(self, name: str, version: str | None = None, title: str | None = None, description: str | None = None, ...) Previously, self.description was passed as the second positional argument, which incorrectly mapped to the version parameter instead of description. Fixes tadata-org#272
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there! 👋
Found a small bug while reading through the codebase - the
descriptionparameter was being passed positionally toServer(), which actually maps it to theversionparameter instead ofdescription.The fix:
Changed
Server(self.name, self.description)toServer(self.name, description=self.description)to ensure the description goes to the right place.This should fix #272 🙂
Noticed this while exploring how the MCP server gets initialized - loving the clean architecture of this project btw! The ASGI transport approach is really elegant.
Let me know if you need any changes!