Skip to content

Commit 5dfa5fb

Browse files
tae2089claude
andcommitted
fix: remove unused infoMap param from batchSymbolNodes, improve test error handling
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 20a9bac commit 5dfa5fb

2 files changed

Lines changed: 18 additions & 7 deletions

File tree

internal/ragindex/builder.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ func (b *Builder) Build() (int, int, error) {
107107
}
108108

109109
// 4. @intent 태그를 가진 symbol 노드 배치 조회
110-
symbolsByFile, err := b.batchSymbolNodes(allNodeIDs, nodeInfoMap)
110+
symbolsByFile, err := b.batchSymbolNodes(allNodeIDs)
111111
if err != nil {
112112
return 0, 0, fmt.Errorf("batchSymbolNodes: %w", err)
113113
}
@@ -238,7 +238,7 @@ func (b *Builder) batchFileSummaries(filePaths []string) (map[string]string, err
238238

239239
// batchSymbolNodes는 @intent 태그를 가진 노드를 filePath → []*TreeNode 맵으로 반환한다.
240240
// 노드당 첫 번째 @intent 값만 summary로 사용한다.
241-
func (b *Builder) batchSymbolNodes(nodeIDs []uint, infoMap map[uint]nodeInfo) (map[string][]*TreeNode, error) {
241+
func (b *Builder) batchSymbolNodes(nodeIDs []uint) (map[string][]*TreeNode, error) {
242242
result := make(map[string][]*TreeNode)
243243
if len(nodeIDs) == 0 {
244244
return result, nil

internal/ragindex/builder_test.go

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,9 @@ func TestBuilder_SymbolNodes(t *testing.T) {
408408
if err := db.Create(&fileNode).Error; err != nil {
409409
t.Fatalf("create file node: %v", err)
410410
}
411-
db.Create(&model.CommunityMembership{CommunityID: comm.ID, NodeID: fileNode.ID})
411+
if err := db.Create(&model.CommunityMembership{CommunityID: comm.ID, NodeID: fileNode.ID}).Error; err != nil {
412+
t.Fatalf("create membership: %v", err)
413+
}
412414

413415
// function 노드 (같은 파일, community 멤버, @intent 태그 있음)
414416
funcNode := model.Node{
@@ -422,12 +424,18 @@ func TestBuilder_SymbolNodes(t *testing.T) {
422424
if err := db.Create(&funcNode).Error; err != nil {
423425
t.Fatalf("create func node: %v", err)
424426
}
425-
db.Create(&model.CommunityMembership{CommunityID: comm.ID, NodeID: funcNode.ID})
427+
if err := db.Create(&model.CommunityMembership{CommunityID: comm.ID, NodeID: funcNode.ID}).Error; err != nil {
428+
t.Fatalf("create membership: %v", err)
429+
}
426430

427431
// @intent annotation + tag 생성
428432
ann := model.Annotation{NodeID: funcNode.ID, Summary: "로그인 핸들러"}
429-
db.Create(&ann)
430-
db.Create(&model.DocTag{AnnotationID: ann.ID, Kind: model.TagIntent, Value: "로그인 요청을 처리하고 JWT를 반환한다", Ordinal: 0})
433+
if err := db.Create(&ann).Error; err != nil {
434+
t.Fatalf("create annotation: %v", err)
435+
}
436+
if err := db.Create(&model.DocTag{AnnotationID: ann.ID, Kind: model.TagIntent, Value: "로그인 요청을 처리하고 JWT를 반환한다", Ordinal: 0}).Error; err != nil {
437+
t.Fatalf("create doc tag: %v", err)
438+
}
431439

432440
b := &ragindex.Builder{
433441
DB: db,
@@ -489,7 +497,10 @@ func TestBuilder_NoSymbolsWithoutIntent(t *testing.T) {
489497
t.Fatalf("Build: %v", err)
490498
}
491499

492-
idx, _ := ragindex.LoadIndex(filepath.Join(tmpDir, "doc-index.json"))
500+
idx, err := ragindex.LoadIndex(filepath.Join(tmpDir, "doc-index.json"))
501+
if err != nil {
502+
t.Fatalf("LoadIndex: %v", err)
503+
}
493504
if len(idx.Root.Children) == 0 || len(idx.Root.Children[0].Children) == 0 {
494505
t.Fatal("expected file node")
495506
}

0 commit comments

Comments
 (0)