Skip to content

[test] [llvm] Add bool to builder #8687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hughperkins wants to merge 3 commits into from
Closed

[test] [llvm] Add bool to builder #8687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39d5432
adding boolean to builder
hughperkins Apr 26, 2025
bfe008b
better builder test
hughperkins Apr 26, 2025
15495b5
remove unused print from bool
hughperkins May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions taichi/ir/ir_builder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,12 @@ LoopIndexStmt *IRBuilder::get_loop_index(Stmt *loop, int index) {
return insert(Stmt::make_typed<LoopIndexStmt>(loop, index));
}

ConstStmt *IRBuilder::get_bool(bool value) {
return insert(Stmt::make_typed<ConstStmt>(TypedConstant(
TypeFactory::get_instance().get_primitive_type(PrimitiveTypeID::u1),
value)));
}

ConstStmt *IRBuilder::get_int32(int32 value) {
return insert(Stmt::make_typed<ConstStmt>(TypedConstant(
TypeFactory::get_instance().get_primitive_type(PrimitiveTypeID::i32),
Expand Down
1 change: 1 addition & 0 deletions taichi/ir/ir_builder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ class IRBuilder {
LoopIndexStmt *get_loop_index(Stmt *loop, int index = 0);

// Constants. TODO: add more types
ConstStmt *get_bool(bool value);
ConstStmt *get_int32(int32 value);
ConstStmt *get_int64(int64 value);
ConstStmt *get_uint32(uint32 value);
Expand Down
18 changes: 18 additions & 0 deletions tests/cpp/ir/ir_builder_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,30 @@
#include "taichi/ir/statements.h"
#include "tests/cpp/program/test_program.h"
#include "tests/cpp/ir/ndarray_kernel.h"
#include "taichi/ir/transforms.h"
#ifdef TI_WITH_VULKAN
#include "taichi/rhi/vulkan/vulkan_loader.h"
#endif

namespace taichi::lang {

TEST(IRBuilder, Bool) {
IRBuilder builder;
auto *bool_true = builder.get_bool(true);
auto *bool_false = builder.get_bool(false);
builder.create_and(bool_true, bool_false);
auto block = builder.extract_ir();

std::string ir_string;
irpass::print(block->get_ir_root(), &ir_string);
EXPECT_STREQ(ir_string.c_str(), R"(kernel {
<u1> $0 = const true
<u1> $1 = const false
$2 = bit_and $0 $1
}
)");
}

TEST(IRBuilder, Basic) {
IRBuilder builder;
auto *lhs = builder.get_int32(40);
Expand Down
Loading