[build] [mac] Fix mac build symbol export failure#8690
Merged
feisuzhu merged 1 commit intoApr 27, 2025
Conversation
Contributor
Author
|
Thank you! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #
Brief Summary
Fixes exported name check on mac build, by looking for .dylib instead of .so
copilot:summary
Walkthrough
Currently, Mac builds fail on the check exported symbols check, e.g. https://github.com/hughperkins/taichi/actions/runs/14691553460/job/41227531475?pr=2 :
The reason is that, on Mac, this file has '.dylib' extension. E.g. on my own Mac:
This PR updates the exported name check script to look for a .dylib, when building on mac (uname == "Darwin"), which addresses this issue, and should hopefully fix the build.
copilot:walkthrough