Skip to content

[ci] Do not setup Vulkan SDK#8692

Merged
feisuzhu merged 4 commits into
taichi-dev:masterfrom
feisuzhu:ci-no-vksdk
Apr 29, 2025
Merged

[ci] Do not setup Vulkan SDK#8692
feisuzhu merged 4 commits into
taichi-dev:masterfrom
feisuzhu:ci-no-vksdk

Conversation

@feisuzhu
Copy link
Copy Markdown
Contributor

No description provided.

@feisuzhu feisuzhu requested a review from bobcao3 April 27, 2025 14:25
@hughperkins
Copy link
Copy Markdown
Contributor

I'm assuming this will fix the 'not sm70' build issues? 🙌

Note that you can fix the m1 build issue I believe by merging in #8690

@feisuzhu
Copy link
Copy Markdown
Contributor Author

I'm assuming this will fix the 'not sm70' build issues? 🙌

Note that you can fix the m1 build issue I believe by merging in #8690

Wow, didn't notice it, I'll merge your version, thx~

@hughperkins
Copy link
Copy Markdown
Contributor

Hmmm, the dylib thing was suffiicent to fix m1 on my mac 🤔. Seems it is missing some symbols though 🤔 Will poke at it a bit...

@hughperkins
Copy link
Copy Markdown
Contributor

Oh, actually was failing on my mac too, I just didn't notice 😅

++ nm -C --extern-only /Users/hugh/git/taichi-m1/_skbuild/macosx-15.0-arm64-3.9/cmake-install/python/taichi/_lib/c_api/lib/libtaichi_c_api.dylib
++ grep ' T \| B \| D '
++ grep -v ' _\?ti_'
++ grep -v ' capi::utils::'
++ wc -l
+ NUM_LEAK_SYM='       0'
+ '[' 0 -gt 0 ']'
~/git/taichi-m1 (hp/fix-cannot-name-an-alias-template-for-trigger|…1△3) $ echo $?
0

@feisuzhu
Copy link
Copy Markdown
Contributor Author

@hughperkins It's a bug in previous proxy commit, it should ignore any errors when unsetting git proxy

@feisuzhu
Copy link
Copy Markdown
Contributor Author

Oh, actually was failing on my mac too, I just didn't notice 😅

++ nm -C --extern-only /Users/hugh/git/taichi-m1/_skbuild/macosx-15.0-arm64-3.9/cmake-install/python/taichi/_lib/c_api/lib/libtaichi_c_api.dylib
++ grep ' T \| B \| D '
++ grep -v ' _\?ti_'
++ grep -v ' capi::utils::'
++ wc -l
+ NUM_LEAK_SYM='       0'
+ '[' 0 -gt 0 ']'
~/git/taichi-m1 (hp/fix-cannot-name-an-alias-template-for-trigger|…1△3) $ echo $?
0

It's a success IMHO

@hughperkins
Copy link
Copy Markdown
Contributor

Yeah, I noticed I was misreading the output after I sent it 😅. My brain was like "oh, it didn't find any export symbols". Then later I realized "oh, it didnt find any leaked symbols, and it's ok" :)

@hughperkins
Copy link
Copy Markdown
Contributor

@hughperkins
Copy link
Copy Markdown
Contributor

Ok, M1 build passed here https://github.com/hughperkins/taichi/actions/runs/14693977764/job/41233131358?pr=2 using #8693 (But I'm just throwing away any errors in unsetting git proxy. Not sure if we need to investigate why it produces errors?).

@hughperkins
Copy link
Copy Markdown
Contributor

Oh you already fixed the proxy 🙌

hughperkins added a commit to hughperkins/quadrants that referenced this pull request Apr 27, 2025
@feisuzhu feisuzhu merged commit 4def797 into taichi-dev:master Apr 29, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants