-
Notifications
You must be signed in to change notification settings - Fork 82
.397395619494580:eb91f111a0a5c785d9d2026cd67e3333_69e6210c180bcf8a442e5ffe.69e623c7180bcf8a442e6003.69e623c6966af563bdeec98d:Trae CN.T(2026/4/20 21:01:59) #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yangou-hash
wants to merge
1
commit into
taichi-dev:master
Choose a base branch
from
yangou-hash:ouyu_trae
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wind postprocessor overrides bounding box boundary conditions
Medium Severity
The wind postprocessor is appended to
grid_postprocessafter the bounding box (which is always the first element, added in__init__). During each substep, the bounding box runs first and zeroes out boundary-violating velocities, but thenapply_windadds velocity back, potentially in the outward direction. Unlike existing colliders which only reduce or project velocity, wind adds velocity, so it can override the bounding box constraint and allow particles to escape the simulation domain.Additional Locations (1)
engine/mpm_solver.py#L299-L302Reviewed by Cursor Bugbot for commit e333388. Configure here.