Skip to content
This repository was archived by the owner on Mar 17, 2025. It is now read-only.

fix: use Status.WARN instead of ERROR#67

Open
azu wants to merge 1 commit into
taichi:mainfrom
azu:fix-output-error
Open

fix: use Status.WARN instead of ERROR#67
azu wants to merge 1 commit into
taichi:mainfrom
azu:fix-output-error

Conversation

@azu

@azu azu commented Jul 16, 2023

Copy link
Copy Markdown
Contributor

If ERROR is set to ERROR, the OUTPUT panel opens, so use WARNING instead.

This PR changes the behaviour when opening a project without textlint installed.

BEFORE

vscode-textlint was ERROR

image

AFTER

vscode-textlint will be WARNNING

image

fix #66
cc @taichi

- If ERROR is set to ERROR, the OUTPUT panel opens, so use WARNING instead.
@piranna

piranna commented Aug 30, 2023

Copy link
Copy Markdown

Can this be merged? I'm facing the same issue.

@piranna

piranna commented Oct 12, 2023

Copy link
Copy Markdown

Any update on this? How can we move it forward besides remove the extension? This issue is very annoying... :-(

@piranna

piranna commented Mar 10, 2024

Copy link
Copy Markdown

After reviewing this, I think in fact the error is legitim: the textlint executable is not being found, that can be considered that's actually an error. Point is, if there's no .textlint file, that's a totally acceptable use case that should show a warning instead, but the executable should not be looked at all. So I think this PR should address that:

  1. look for the .textlint file, if it doesn't exists, show a warning a do anything else
  2. look for the textlint executable, if it doesn't exists, show an error as currently does

Our princess is in another castle... :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The OUTPUT panel opens automatically in workspaces where textlint is not installed.

2 participants