Implemented --ignore-unknown-features with --include-features.#300
Open
Zenithsiz wants to merge 1 commit into
Open
Implemented --ignore-unknown-features with --include-features.#300Zenithsiz wants to merge 1 commit into
--ignore-unknown-features with --include-features.#300Zenithsiz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
--ignore-unknown-featureswith--include-features.The fix just filters all features by whether the package has them before returning them from
determine_kind, but I'm not sure if this can miss any features.The feature type decides whether or not it's filtered:
--include-deps-features, and that is incompatible with--include-features, but it may be worth it at at least check that the dependency exists when filtering? (Although we can't check if the dependency feature exists, since we don't have access to that manifest)All tests, including the one added for this specific case passed.
It's my first time both reading the codebase and contributing, so if I've missed anything, please tell me.