refactor(editor): replace reedline with rustyline completer (#3399)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Author: amitksingh1490

Cargo.lock

@@ -63,7 +63,6 @@ posthog-rs = "0.7.0"
 pretty_assertions = "1.4.1"
 proc-macro2 = "1.0"
 quote = "1.0"
-reedline = "=0.47.0"
 rustyline = "18.0.0"
 regex = "1.12.3"
 reqwest = { version = "0.12.23", features = [

Cargo.toml

@@ -39,8 +39,7 @@ colored.workspace = true
 anyhow.workspace = true
 derive_setters.workspace = true
 lazy_static.workspace = true
-reedline.workspace = true
-crossterm = "0.29.0"
+rustyline.workspace = true
 nu-ansi-term.workspace = true
 tracing.workspace = true
 chrono.workspace = true

crates/forge_main/Cargo.toml

@@ -1,8 +1,9 @@
 use std::sync::Arc;
 
 use forge_select::ForgeWidget;
-use reedline::{Completer, Span, Suggestion};
 
+use crate::completer::input_completer::InputSuggestion;
+use crate::completer::search_term::Span;
 use crate::model::{ForgeCommand, ForgeCommandManager};
 
 /// A display wrapper for `ForgeCommand` that renders the name and description
@@ -25,8 +26,8 @@ impl CommandCompleter {
     }
 }
 
-impl Completer for CommandCompleter {
-    fn complete(&mut self, line: &str, _: usize) -> Vec<reedline::Suggestion> {
+impl CommandCompleter {
+    pub fn complete(&mut self, line: &str, _: usize) -> Vec<InputSuggestion> {
         // Determine which sentinel the user typed (`:` or `/`), defaulting to `/`.
         let sentinel = if line.starts_with(':') { ':' } else { '/' };
 
@@ -74,15 +75,10 @@ impl Completer for CommandCompleter {
 
         match builder.prompt() {
             Ok(Some(row)) => {
-                vec![Suggestion {
+                vec![InputSuggestion {
                     value: row.0.name,
-                    description: None,
-                    style: None,
-                    extra: None,
                     span: Span::new(0, line.len()),
                     append_whitespace: true,
-                    match_indices: None,
-                    display_override: None,
                 }]
             }
             _ => vec![],

crates/forge_main/src/completer/command.rs

@@ -3,10 +3,9 @@ use std::sync::Arc;
 
 use forge_select::{ForgeWidget, PreviewLayout, PreviewPlacement, SelectRow};
 use forge_walker::Walker;
-use reedline::{Completer, Span, Suggestion};
 
 use crate::completer::CommandCompleter;
-use crate::completer::search_term::SearchTerm;
+use crate::completer::search_term::{SearchTerm, Span};
 use crate::model::ForgeCommandManager;
 
 pub fn select_workspace_file(cwd: &Path, query: Option<String>) -> anyhow::Result<Option<String>> {
@@ -60,14 +59,18 @@ pub struct InputCompleter {
     command: CommandCompleter,
 }
 
+pub struct InputSuggestion {
+    pub value: String,
+    pub span: Span,
+    pub append_whitespace: bool,
+}
+
 impl InputCompleter {
     pub fn new(cwd: PathBuf, command_manager: Arc<ForgeCommandManager>) -> Self {
         Self { cwd, command: CommandCompleter::new(command_manager) }
     }
-}
 
-impl Completer for InputCompleter {
-    fn complete(&mut self, line: &str, pos: usize) -> Vec<Suggestion> {
+    pub fn complete(&mut self, line: &str, pos: usize) -> Vec<InputSuggestion> {
         if line.starts_with('/') || line.starts_with(':') {
             // if the line starts with '/' or ':' it's probably a command, so we delegate to
             // the command completer.
@@ -86,15 +89,10 @@ impl Completer for InputCompleter {
 
             if let Ok(Some(selected)) = select_workspace_file(&self.cwd, initial_text) {
                 let value = format!("[{}]", selected);
-                return vec![Suggestion {
-                    description: None,
+                return vec![InputSuggestion {
                     value,
-                    style: None,
-                    extra: None,
                     span: Span::new(query.span.start, query.span.end),
                     append_whitespace: true,
-                    match_indices: None,
-                    display_override: None,
                 }];
             }
         }

crates/forge_main/src/completer/input_completer.rs

@@ -1,4 +1,14 @@
-use reedline::Span;
+#[derive(Clone, Debug, PartialEq, Eq)]
+pub struct Span {
+    pub start: usize,
+    pub end: usize,
+}
+
+impl Span {
+    pub fn new(start: usize, end: usize) -> Self {
+        Self { start, end }
+    }
+}
 
 pub struct SearchTerm {
     line: String,