Skip to content

Commit 0b510f6

Browse files
committed
refactor(core): minimize diff with main in collection hooks
- remove unnecessary setPageSize wrapper in use-collection-variables - restore cursor pagination tests removed by unrelated changes
1 parent 4093ece commit 0b510f6

2 files changed

Lines changed: 26 additions & 8 deletions

File tree

packages/core/src/hooks/use-collection-variables.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ export function useCollectionVariables(
152152
resetPage,
153153
goToFirstPage,
154154
goToLastPage,
155-
setPageSize: setCursorPageSize,
155+
setPageSize,
156156
getHasPrevPage,
157157
getHasNextPage,
158158
resetCount,
@@ -248,13 +248,6 @@ export function useCollectionVariables(
248248
resetPage();
249249
}, [resetPage]);
250250

251-
const setPageSize = useCallback(
252-
(size: number) => {
253-
setCursorPageSize(size);
254-
},
255-
[setCursorPageSize],
256-
);
257-
258251
// ---------------------------------------------------------------------------
259252
// Build collection variables (Tailor Platform format)
260253
// ---------------------------------------------------------------------------

packages/core/src/hooks/use-cursor-pagination.test.ts

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ describe("useCursorPagination", () => {
1212
expect(result.current.cursor).toBeNull();
1313
expect(result.current.cursorStack).toEqual([]);
1414
expect(result.current.paginationDirection).toBe("forward");
15+
expect(result.current.pageSize).toBe(20);
1516
});
1617

1718
it("returns correct initial paginationVariables", () => {
@@ -183,6 +184,24 @@ describe("useCursorPagination", () => {
183184
});
184185
});
185186

187+
// ---------------------------------------------------------------------------
188+
// setPageSize
189+
// ---------------------------------------------------------------------------
190+
describe("setPageSize", () => {
191+
it("changes page size and resets to first page", () => {
192+
const { result } = renderHook(() => useCursorPagination(20));
193+
194+
act(() => result.current.goToNextPage({ endCursor: "c1" }));
195+
act(() => result.current.setPageSize(50));
196+
197+
expect(result.current.pageSize).toBe(50);
198+
expect(result.current.cursor).toBeNull();
199+
expect(result.current.cursorStack).toEqual([]);
200+
expect(result.current.paginationDirection).toBe("forward");
201+
expect(result.current.paginationVariables).toEqual({ first: 50 });
202+
});
203+
});
204+
186205
// ---------------------------------------------------------------------------
187206
// paginationVariables shape
188207
// ---------------------------------------------------------------------------
@@ -280,5 +299,11 @@ describe("useCursorPagination", () => {
280299
act(() => result.current.goToLastPage());
281300
expect(result.current.resetCount).toBe(0);
282301
});
302+
303+
it("does not increment on setPageSize", () => {
304+
const { result } = renderHook(() => useCursorPagination(20));
305+
act(() => result.current.setPageSize(50));
306+
expect(result.current.resetCount).toBe(0);
307+
});
283308
});
284309
});

0 commit comments

Comments
 (0)