feat(action-panel): add variant prop to ActionItem for destructive styling#301
Merged
Conversation
0c02977 to
f605fc6
Compare
commit: |
Contributor
|
If you click on the whole row, does it trigger the event? As in is it basically acting as a button now? |
Contributor
Author
Yes. No change from the current behaviour of |
Contributor
|
Ah yeap, I checked the code and I can see it's semantically correct (it's a I feel like we should enforce that if you add a |
erickteowarang
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an optional
variantprop toActionItemso that dangerous actions (e.g. "Delete") can be styled with destructive (red) text color in theActionPanel.Usage
Notes
Non-breaking:
variantis optional and defaults to"default"(existing behavior unchanged)