Skip to content

fix: add explicit border-border to border-width-only utilities#321

Merged
IzumiSy merged 1 commit into
mainfrom
fix/border-border-missing-color
Jun 17, 2026
Merged

fix: add explicit border-border to border-width-only utilities#321
IzumiSy merged 1 commit into
mainfrom
fix/border-border-missing-color

Conversation

@IzumiSy

@IzumiSy IzumiSy commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Components using directional border-width utilities (border-b, border-t, border-l, border-r) relied on the global * { border-color: var(--border) } rule in @layer base. When consumers import Tailwind CSS after app-shell styles, Tailwind's preflight resets border-color via shorthand, causing thick dark borders (currentColor).

This is a follow-up to #317 which fixed astw:border (all-side) usages but missed directional variants.

Screen shots (bugs to be fixed in this PR)

Unnecessary black borders.

Table

スクリーンショット 2026-06-17 12 14 08

Sheet

スクリーンショット 2026-06-17 12 14 47

CSV Importer

スクリーンショット 2026-06-17 12 15 05

Fix

Adding explicit astw:border-border at the utility layer ensures the correct color regardless of CSS import order.

Affected Components

Component File
Sheet packages/core/src/components/sheet.tsx
Table packages/core/src/components/table.tsx
CsvImporter packages/core/src/components/csv-importer/CsvImporter.tsx
CommandPalette packages/core/src/components/command-palette.tsx
DataTable packages/core/src/components/data-table/data-table.tsx
DataTable.Toolbar packages/core/src/components/data-table/toolbar.tsx

Testing

All 60 test files (1120 tests) pass. 8 snapshots updated to reflect the added border-border class.

@IzumiSy IzumiSy self-assigned this Jun 17, 2026
@IzumiSy IzumiSy requested a review from a team June 17, 2026 03:16
Components using directional border-width utilities (border-b, border-t,
border-l, border-r) relied on the global `* { border-color: var(--border) }`
rule in `@layer base`. When consumers import Tailwind CSS after app-shell
styles, Tailwind's preflight resets border-color via shorthand, causing
thick dark borders (currentColor).

Adding explicit `astw:border-border` at the utility layer ensures the
correct color regardless of CSS import order.

Affected components: Sheet, Table, CsvImporter, CommandPalette, DataTable,
DataTable.Toolbar.
@IzumiSy IzumiSy force-pushed the fix/border-border-missing-color branch from 18e11bf to 87e054e Compare June 17, 2026 03:30
@IzumiSy IzumiSy merged commit a4cbf84 into main Jun 17, 2026
4 of 5 checks passed
@IzumiSy IzumiSy deleted the fix/border-border-missing-color branch June 17, 2026 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants