Align theme docs and palette templates#330
Merged
Merged
Conversation
IzumiSy
force-pushed
the
fix/theme-docs-alignment
branch
from
50190f3 to
3e96c83
Compare
IzumiSy
commented
Jun 24, 2026
| | --------------------- | --------------------- | ------------------------------------------------------------- | | ||
| | **1. Brand** | Yes | `primary`, `secondary`, `accent` (+ foregrounds) — both modes | | ||
| | **2. Shell gradient** | Branded palettes only | `--shell-gradient-base`, `--shell-gradient-tint` | | ||
| | **3. Derived** | Copy verbatim | Ring, sidebar aliases, gradient stops — do not edit | |
Contributor
Author
There was a problem hiding this comment.
Removed Derived here
IzumiSy
force-pushed
the
fix/theme-docs-alignment
branch
from
e49ff84 to
0c3b5db
Compare
interacsean
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a small follow-up to the theme foundation work in #306. The theme model itself is already in place, but some of the public guidance still reflected earlier assumptions, which made palette authoring look more complex than the shipped API really is.
This PR tightens that up by:
@tailor-platform/app-shell/stylesand optional@tailor-platform/app-shell/themes/*default.cssinstead of something each branded theme has to repeatbase+tint)--shell-gradient-start/--shell-gradient-endderived vars, since themes and core styles both read directly frombase+tintWhy this follow-up matters
The previous theme foundation PR established the implementation, but there was still drift between:
That drift showed up as concepts that looked public but are not really part of the author-facing API anymore, such as
defaultThemePalette,data-theme, and derived shell gradient tokens. This PR removes that ambiguity so future palette work starts from the same mental model as the shipped code.