feat: remove page-level loaders from AppShellPageProps#334
Merged
Conversation
AppShellPageProps
erickteowarang
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes
loaderfrom file-based page definitions (Page.appShellPageProps) and makesguardsthe only source of page-level route behavior in file-based routing. As part of that cleanup, route conversion now derives loaders only fromguards, and the Vite plugin schema/validator now rejectsloaderonappShellPageProps. The docs and changeset have been updated to reflect the breaking change.Why
loaderon file-based pages was accidentally exposed but incomplete:guards, because an explicit page loader took precedence over the guard-backed loaderModule/Resourcecarry an internalloaderfor guard wiring, butdefineModule/defineResourcedo not exposeloaderas a public input propguards, not ad hoc loadersGuard behavior
guards: no behavior changeguards+loader:guardsnow run consistently because the page loader is no longer readThis means the guard story is now simpler and more predictable: if a page declares
guards, those guards are what control redirect/404 behavior.Practical impact
Based on a survey of existing projects, we did not observe current usage of page-level
loaderinAppShellPageProps, so the practical migration impact should be negligible.