docs(skill): update app-shell-patterns for new components (1.7.0)#359
Merged
Conversation
Sync the app-shell-patterns skill with components shipped since 0.36.0: - Bump documented AppShell version 0.36.0 -> 1.7.0 - Add Grid entry + make it the canonical wrapper for metric/KPI strips - Add DocumentProgressCard entry (lifecycle/fulfilment progress card) - Document Table Head/Cell `align` (left|center|right) and DataTable Column `align` (numeric auto-right); switch examples off ad-hoc classes - Expand Badge to the full 15-variant set (filled / subtle / outline-*) with a primary/secondary status split - Document standalone accessible-name props on Select/Combobox/Autocomplete - Add cross-cutting UX + composition & emphasis rules (one primary action, no duplicate actions, action placement, metric tiles in Grid, forms default to modal, handle loading/empty/error states) - Refine detail/hero-with-actions layout variants and list/dense-scan status-variant guidance to match the primary/secondary badge split Reference images are intentionally left out of this PR and will follow separately. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Complete the component-coverage pass on the app-shell-patterns skill: - Add missing component entries: Alert (variant/action/dismissible) and Tabs (Root/List/Tab/Panel, variant default|line|capsule) - Fix doc bug: Layout example used Tabs.Trigger; real subcomponent is Tabs.Tab - Wire up broken bidirectional links — Grid, MetricCard, DocumentProgressCard were documented as "Used in patterns: detail/*" but never referenced back. Add them to detail/hero-with-actions requiredImports + a new "Optional cards" section (metric strip, progress card, inline Alert) - Demonstrate the new alignment props in pattern examples: Table.Head/Cell align="right" on numeric columns (detail), DataTable Column.align on the Amount column (list-dense-scan) Reference images remain excluded (separate PR). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Run oxfmt on the docs touched in this branch (the earlier commits skipped the pre-commit hook while local Node was on the wrong major). No content changes — emphasis-marker normalization and requiredImports array wrapping. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
interacsean
approved these changes
Jul 3, 2026
Adopt the repo's "<does X>. Use when: …" convention so the skill triggers on UI-building intent (list/table/form/modal/wizard/interaction) and states the app-shell-installed precondition, instead of the passive "catalog" phrasing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs the
app-shell-patternsskill (packages/core/skills/app-shell-patterns/) with components and APIs shipped since the docs were last pinned at0.36.0, and repairs the cross-references between the component catalog and the pattern files. Docs-only — no source changes.Reference images (
references/images/) are intentionally excluded and will land in a separate follow-up PR.New / updated component docs
0.36.0→1.7.0.Grid— new entry; canonical wrapper for metric/KPI strips (never one-per-row).DocumentProgressCard— new entry (presentational lifecycle/fulfilment card).Alert— new entry (inline banner;variant/action/dismissible).Tabs— new entry (Root/List/Tab/Panel,variantdefault|line|capsule). Also fixes a doc bug: the Layout example usedTabs.Trigger, but the real subcomponent isTabs.Tab.Table.Head/Table.Cellalign(left|center|right) andDataTableColumn.align(numerictypeauto-right); examples switched off ad-hoctext-rightclasses.Badge— expanded to the full 15-variant set (filled /subtle-*/outline-*) with a primary vs. secondary status split.Select/Combobox/Autocomplete— documented the standalone accessible-name props (aria-label/aria-labelledby/id).Interlinking fixes
Grid,MetricCard,DocumentProgressCard,Alert,Tabswere documented but not referenced back from any pattern. All five are now wired intodetail/hero-with-actions(requiredImports+ a new "Optional cards" section) and/orlist/dense-scan, so every "Used in patterns" claim resolves bidirectionally.Cross-cutting rules
Grid, forms default to modal, and handling loading/empty/error states.🤖 Generated with Claude Code