Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
Code Metrics Report
Code coverage of files in pull request scope (20.6%)
Reported by octocov |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new pipeline resolver step coverage feature and improves the user experience of several commands by adding a spinner to indicate progress. It also enhances the flexibility of resource loading with new options and adds support for fetching resolver execution results for coverage calculation. Several new dependencies are introduced to support these features.
New Coverage Feature:
coveragecommand (cmd/coverage.go) that displays pipeline resolver step coverage, including options for time filtering and detailed reporting. This command uses a newCoveragemethod on theClientto analyze step coverage based on recent execution results. [1] [2]User Experience Improvements:
lintandmetricscommands to provide visual feedback during long-running operations. The spinner is started at the beginning of command execution and stopped before displaying results. [1] [2] [3] [4] [5]Resource Loading Enhancements:
Resourcesloader intailor/resource.goto accept functional options, allowing selective loading of applications, pipelines, TailorDBs, and state flows. Adds support for loading resolver execution results since a specified time, which is necessary for coverage analysis. [1] [2] [3] [4] [5] [6] [7] F8bfd94dL8R8)Dependency Updates:
github.com/briandowns/spinnerfor the spinner, andgithub.com/k1LoW/durationfor parsing duration strings in thecoveragecommand. Updatesgo.modaccordingly.Minor Cleanups:
Let me know if you'd like a walkthrough of how the new coverage feature works or how to use the new resource loading options!