configure DNS on macOS runners#200
Merged
Merged
Conversation
oxtoacart
force-pushed
the
percy/magicdns
branch
11 times, most recently
from
October 3, 2025 12:36
3357f78 to
8d103aa
Compare
oxtoacart
commented
Oct 3, 2025
| version: latest | ||
| ping: 100.99.0.2,lax-pve.pineapplefish.ts.net,lax-pve | ||
|
|
||
| # macOS latest (ARM) |
Collaborator
Author
There was a problem hiding this comment.
Might as well test the latest macOS too.
oxtoacart
force-pushed
the
percy/magicdns
branch
from
October 3, 2025 12:40
8d103aa to
d5aff69
Compare
oxtoacart
changed the title
oxtoacart
marked this pull request as ready for review
October 3, 2025 12:41
oxtoacart
force-pushed
the
percy/magicdns
branch
6 times, most recently
from
October 3, 2025 15:39
74b7a0f to
c8b6ec5
Compare
oxtoacart
force-pushed
the
percy/magicdns
branch
from
October 3, 2025 16:01
c8b6ec5 to
edbe89e
Compare
mpminardi
reviewed
Oct 3, 2025
| `--authkey=${finalAuthKey}`, | ||
| `--hostname=${hostname}`, | ||
| "--accept-routes", | ||
| "--accept-dns", |
Member
There was a problem hiding this comment.
I think this is defaulted to true but doesn't hurt to be explicit!
Member
There was a problem hiding this comment.
Whoops added this on the dist/ file accidentally, might be good to mark this folder as generated so GitHub auto-collapses the diff.
Would be something like a:
/dist/* linguist-generated=true
in a .gitattributes file IIRC
Collaborator
Author
There was a problem hiding this comment.
Oh oops, that was left over from experimentation.
mpminardi
reviewed
Oct 3, 2025
| core.setFailed( | ||
| `❌ Tailscale status is required in order to configure macOS` | ||
| ); | ||
| process.exit(2); |
Member
There was a problem hiding this comment.
Is there a reason we exit with status code 2 here specifically?
Collaborator
Author
There was a problem hiding this comment.
I just wanted something different so that one can distinguish this particular condition if need be.
mpminardi
approved these changes
Oct 3, 2025
On macOS, `tailscaled` does not manage DNS. Configure it manually in the GitHub action to make sure MagicDNS name resolution works. Updates tailscale/corp#32821 Signed-off-by: Percy Wegmann <percy@tailscale.com>
oxtoacart
force-pushed
the
percy/magicdns
branch
from
October 3, 2025 17:14
edbe89e to
769c197
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS,
tailscaleddoes not manage DNS. Configure it manually in the GitHub action to makesure MagicDNS name resolution works.
Updates tailscale/corp#32821