Skip to content

Commit 92e9c68

Browse files
committed
all: fix errcheck findings in new test code
Silence golangci-lint errcheck warnings for unchecked return values in the new streamlocal and tcpip forwarding tests. Updates gliderlabs#196
1 parent 05598c6 commit 92e9c68

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

streamlocal_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@ func sampleUnixSocketServer(t *testing.T) net.Listener {
6161
if err != nil {
6262
return
6363
}
64-
conn.Write(sampleServerResponse)
65-
conn.Close()
64+
_, _ = conn.Write(sampleServerResponse)
65+
_ = conn.Close()
6666
}()
6767

6868
return l
@@ -87,7 +87,7 @@ func newTestSessionWithUnixForwarding(t *testing.T, forwardingEnabled bool) (net
8787

8888
return l, client, func() {
8989
cleanup()
90-
l.Close()
90+
_ = l.Close()
9191
}
9292
}
9393

@@ -149,14 +149,14 @@ func TestReverseUnixForwardingWorks(t *testing.T) {
149149
if err != nil {
150150
t.Fatalf("failed to listen on a unix socket over SSH %q: %v", remoteSocketPath, err)
151151
}
152-
defer l.Close()
152+
defer l.Close() //nolint:errcheck
153153
go func() {
154154
conn, err := l.Accept()
155155
if err != nil {
156156
return
157157
}
158-
conn.Write(sampleServerResponse)
159-
conn.Close()
158+
_, _ = conn.Write(sampleServerResponse)
159+
_ = conn.Close()
160160
}()
161161

162162
// Dial the listener that should've been created by the server.

tcpip_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,14 +106,14 @@ func TestReverseTCPForwardingWorks(t *testing.T) {
106106
if err != nil {
107107
t.Fatalf("failed to listen on a random TCP port over SSH: %v", err)
108108
}
109-
defer l.Close()
109+
defer l.Close() //nolint:errcheck
110110
go func() {
111111
conn, err := l.Accept()
112112
if err != nil {
113113
return
114114
}
115-
conn.Write(sampleServerResponse)
116-
conn.Close()
115+
_, _ = conn.Write(sampleServerResponse)
116+
_ = conn.Close()
117117
}()
118118

119119
// Dial the listener that should've been created by the server.

0 commit comments

Comments
 (0)