android: require confirmation before disabling remote client logging

Reword the subtitle and add a confirmation dialog when toggling
remote client logging off, since disabling breaks Network Flow
Logs (if required by the tailnet admin) and blocks Tailscale
Support from debugging problems on the device. Turning logging
back on remains a single tap.

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>

Author: bradfitz

android/src/main/java/com/tailscale/ipn/ui/view/SettingsView.kt

@@ -8,13 +8,18 @@ import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.padding
 import androidx.compose.foundation.rememberScrollState
 import androidx.compose.foundation.verticalScroll
+import androidx.compose.material3.AlertDialog
 import androidx.compose.material3.ListItem
 import androidx.compose.material3.MaterialTheme
 import androidx.compose.material3.Scaffold
 import androidx.compose.material3.Text
+import androidx.compose.material3.TextButton
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.collectAsState
 import androidx.compose.runtime.getValue
+import androidx.compose.runtime.mutableStateOf
+import androidx.compose.runtime.remember
+import androidx.compose.runtime.setValue
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.platform.LocalUriHandler
@@ -59,6 +64,7 @@ fun SettingsView(
   val showTailnetLock by MDMSettings.manageTailnetLock.flow.collectAsState()
   val useTailscaleSubnets by MDMSettings.useTailscaleSubnets.flow.collectAsState()
   val isClientRemoteLoggingEnabled by viewModel.isClientRemoteLoggingEnabled.collectAsState()
+  var showDisableLoggingDialog by remember { mutableStateOf(false) }
 
   Scaffold(
       topBar = {
@@ -118,7 +124,13 @@ fun SettingsView(
                       else R.string.client_remote_logging_enabled_subtitle),
               isOn = isClientRemoteLoggingEnabled,
               enabled = !MDMSettings.isMDMConfigured,
-              onToggle = { viewModel.toggleIsClientRemoteLoggingEnabled() })
+              onToggle = {
+                if (isClientRemoteLoggingEnabled) {
+                  showDisableLoggingDialog = true
+                } else {
+                  viewModel.toggleIsClientRemoteLoggingEnabled()
+                }
+              })
 
           if (!AndroidTVUtil.isAndroidTV()) {
             Lists.ItemDivider()
@@ -149,6 +161,29 @@ fun SettingsView(
           }
         }
       }
+
+  if (showDisableLoggingDialog) {
+    AlertDialog(
+        onDismissRequest = { showDisableLoggingDialog = false },
+        title = { Text(stringResource(R.string.client_remote_logging_disable_confirm_title)) },
+        text = { Text(stringResource(R.string.client_remote_logging_disable_confirm_message)) },
+        confirmButton = {
+          TextButton(
+              onClick = {
+                showDisableLoggingDialog = false
+                viewModel.toggleIsClientRemoteLoggingEnabled()
+              }) {
+                Text(
+                    stringResource(R.string.client_remote_logging_disable_confirm_button),
+                    color = MaterialTheme.colorScheme.error)
+              }
+        },
+        dismissButton = {
+          TextButton(onClick = { showDisableLoggingDialog = false }) {
+            Text(stringResource(R.string.cancel))
+          }
+        })
+  }
 }
 
 object Setting {

android/src/main/res/values/strings.xml

@@ -355,8 +355,11 @@
     <string name="use_tailscale_subnets_subtitle">Route traffic according to your network\'s rules. Some networks require this to access IP addresses that don\'t start with 100.x.y.z.</string>
     <string name="subnet_routing">Subnet routing</string>
     <string name="client_remote_logging_enabled">Remote client logging</string>
-    <string name="client_remote_logging_enabled_subtitle">Whether debug logs are uploaded to Tailscale support. When disabled no support or network flow logs.\nChanges require restarting the app to take effect.</string>
+    <string name="client_remote_logging_enabled_subtitle">Whether debug &amp; opt-in flow logs are uploaded. Changes require restarting the app to take effect.</string>
     <string name="client_remote_logging_enabled_subtitle_mdm">Client logging is always enabled for devices under remote management.</string>
+    <string name="client_remote_logging_disable_confirm_title">Disable remote client logging?</string>
+    <string name="client_remote_logging_disable_confirm_message">Disabling remote client logging will break Network Flow Logs if enabled and required by your tailnet admin, and will prevent Tailscale Support from being able to help debug problems with this device.\n\nChanges require restarting the app to take effect.</string>
+    <string name="client_remote_logging_disable_confirm_button">Yes, disable</string>
     <string name="specifies_a_device_name_to_be_used_instead_of_the_automatic_default">Specifies a device name to be used instead of the automatic default.</string>
     <string name="hostname">Hostname</string>
     <string name="failed_to_save">Failed to save</string>