libtailscale: use b.netmon and sys.Bus consistently#717
Merged
Conversation
fixes tailscale/android#17747 There was a mismatch between the netmon into which we were injecting network change events, and the netmon that the eventBus registered with in the userspace engine. The switch from directly registering callbacks with netmon to using the eventBus caused a regression where the injected events would no longer trigger interface rebinds based on feedback from the Android network monitoring APIs. Signed-off-by: Jonathan Nobels <jonathan@tailscale.com>
cmol
approved these changes
Nov 21, 2025
barnstar
added a commit
that referenced
this pull request
Nov 24, 2025
fixes tailscale/android#17747 There was a mismatch between the netmon into which we were injecting network change events, and the netmon that the eventBus registered with in the userspace engine. The switch from directly registering callbacks with netmon to using the eventBus caused a regression where the injected events would no longer trigger interface rebinds based on feedback from the Android network monitoring APIs. Signed-off-by: Jonathan Nobels <jonathan@tailscale.com> (cherry picked from commit 24b6c48)
This was referenced Nov 25, 2025
nadeemakhter0602
pushed a commit
to nadeemakhter0602/TailMon
that referenced
this pull request
Mar 22, 2026
fixes tailscale/android#17747 There was a mismatch between the netmon into which we were injecting network change events, and the netmon that the eventBus registered with in the userspace engine. The switch from directly registering callbacks with netmon to using the eventBus caused a regression where the injected events would no longer trigger interface rebinds based on feedback from the Android network monitoring APIs. Signed-off-by: Jonathan Nobels <jonathan@tailscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes tailscale/tailscale#17747
There was a mismatch between the netmon into which we were injecting network change events, and the netmon that the eventBus registered with in the userspace engine.
The switch from directly registering callbacks with netmon to using the eventBus caused a regression where the injected events would no longer trigger interface rebinds based on feedback from the Android network monitoring APIs.
With a phone with both cell and wifi, swap between the two and ensure we're registering the proper LinkChange: major events and the corresponding rebinds in the userspace engine.