Conversation
vpnPrepared tracks whether Tailscale holds VPN permission. When permission is revoked, the VPNService must be reestablished. If vpnPrepared stays true, the Go backend reconnects, but startVPN() is not called in the ConnectView and the tunnel is not reestablished Updates tailscale/tailscale#17190 Signed-off-by: kari-ts <kari@tailscale.com>
kari-ts
added a commit
that referenced
this pull request
Feb 28, 2026
QuickToggleService was not checking whether or not Tailscale had VPN permission, resulting in a bug where if VPN permission had been revoked, Tailscale would not start properly. This fixes it by maybe launching MainActivity, which gets permission. This is dependent on #748, which sets vpnPrepared on revocation. Updates tailscale/tailscale#17190 Signed-off-by: kari-ts <kari@tailscale.com>
barnstar
approved these changes
Mar 2, 2026
kari-ts
added a commit
that referenced
this pull request
Mar 2, 2026
#749) QuickToggleService was not checking whether or not Tailscale had VPN permission, resulting in a bug where if VPN permission had been revoked, Tailscale would not start properly. This fixes it by maybe launching MainActivity, which gets permission. This is dependent on #748, which sets vpnPrepared on revocation. Updates tailscale/tailscale#17190 Signed-off-by: kari-ts <kari@tailscale.com>
nadeemakhter0602
pushed a commit
to nadeemakhter0602/TailMon
that referenced
this pull request
Mar 22, 2026
vpnPrepared tracks whether Tailscale holds VPN permission. When permission is revoked, the VPNService must be reestablished. If vpnPrepared stays true, the Go backend reconnects, but startVPN() is not called in the ConnectView and the tunnel is not reestablished Updates tailscale/tailscale#17190 Signed-off-by: kari-ts <kari@tailscale.com>
nadeemakhter0602
pushed a commit
to nadeemakhter0602/TailMon
that referenced
this pull request
Mar 22, 2026
tailscale#749) QuickToggleService was not checking whether or not Tailscale had VPN permission, resulting in a bug where if VPN permission had been revoked, Tailscale would not start properly. This fixes it by maybe launching MainActivity, which gets permission. This is dependent on tailscale#748, which sets vpnPrepared on revocation. Updates tailscale/tailscale#17190 Signed-off-by: kari-ts <kari@tailscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vpnPrepared tracks whether Tailscale holds VPN permission. When permission is revoked, the VPNService must be reestablished. If vpnPrepared stays true, the Go backend reconnects, but startVPN() is not called in the ConnectView and the tunnel is not reestablished
Updates tailscale/tailscale#17190