Skip to content

android: fix health warnings sort order #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kari-ts merged 1 commit into from
May 13, 2026
Merged

android: fix health warnings sort order #789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions android/src/main/java/com/tailscale/ipn/ui/model/Health.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,19 @@ class Health {

override fun compareTo(other: UnhealthyState): Int {
// Compare by severity first
val severityComparison = Severity.compareTo(other.Severity)
val severityComparison = other.Severity.compareTo(other.Severity)
if (severityComparison != 0) {
return severityComparison
}

// If severities are equal, compare by warnableCode
// If severities are equal, connectivity impacting issues first
val connectivityComparison =
(other.ImpactsConnectivity ?: false).compareTo(ImpactsConnectivity ?: false)
if (connectivityComparison != 0) {
return connectivityComparison
}

// Otherwise, alphabetical by WarnableCode
return WarnableCode.compareTo(other.WarnableCode)
}
}
Expand Down
Loading