.github/workflows: add containers.yaml#46
Merged
Conversation
mostlygeek
force-pushed
the
mostlygeek/containers
branch
from
c360488 to
47d54d2
Compare
awly
reviewed
Sep 18, 2025
| if [[ "$REF" == refs/tags/* ]]; then | ||
| TAG="${REF#refs/tags/}" | ||
| else | ||
| TAG="latest" |
Member
There was a problem hiding this comment.
this will end up outputting the latest tag twice.
maybe just echo the tags here and above, and exit?
mostlygeek
force-pushed
the
mostlygeek/containers
branch
from
0c6b1e2 to
c3d70df
Compare
Add a GH action to build and publish a docker container when a new tag is pushed. Updates #41 Signed-off-by: Benson Wong <benson@tailscale.com>
mostlygeek
force-pushed
the
mostlygeek/containers
branch
from
c3d70df to
496c292
Compare
Contributor
Author
|
@awly thanks for the earlier review. Incorporated your feedback please take another look. |
awly
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a GH action to build and publish a docker container when a new tag is pushed.
Updates #41