Skip to content

Fix strict pnpm type resolution for @headlessui/react #3869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raashish1601 wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −2
Open

Fix strict pnpm type resolution for @headlessui/react #3869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/@headlessui-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,19 @@
"clean": "rimraf ./dist"
},
"peerDependencies": {
"@types/react": "*",
"@types/react-dom": "*",
"react": "^18 || ^19 || ^19.0.0-rc",
"react-dom": "^18 || ^19 || ^19.0.0-rc"
},
"peerDependenciesMeta": {
"@types/react": {
"optional": true
},
"@types/react-dom": {
"optional": true
}
},
"devDependencies": {
"@testing-library/react": "^15.0.7",
"@types/react": "^18.3.3",
Expand Down
7 changes: 5 additions & 2 deletions packages/@headlessui-react/src/internal/floating.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
useInnerOffset,
useInteractions,
type InnerProps,
type ReferenceType,
type UseFloatingReturn,
} from '@floating-ui/react'
import * as React from 'react'
Expand Down Expand Up @@ -73,9 +74,11 @@ export type InternalFloatingPanelProps = Partial<{
}
}>

type FloatingReference = (node: ReferenceType | null) => void

let FloatingContext = createContext<{
styles?: UseFloatingReturn<any>['floatingStyles']
setReference: UseFloatingReturn<any>['refs']['setReference']
setReference: FloatingReference
setFloating: UseFloatingReturn<any>['refs']['setFloating']
getReferenceProps: ReturnType<typeof useInteractions>['getReferenceProps']
getFloatingProps: ReturnType<typeof useInteractions>['getFloatingProps']
Expand Down Expand Up @@ -106,7 +109,7 @@ export function useResolvedAnchor<T extends AnchorProps | AnchorPropsWithSelecti
}, [anchor])
}

export function useFloatingReference() {
export function useFloatingReference(): FloatingReference {
return useContext(FloatingContext).setReference
}

Expand Down