Skip to content

docs: fix article grammar in tests #3877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oab24413gmai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: fix article grammar in tests #3877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/@headlessui-react/src/components/combobox/combobox.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4155,7 +4155,7 @@ describe.each([{ virtual: true }, { virtual: false }])(
await press(Keys.Backspace)
expect(getComboboxInput()?.value).toBe('')

// Verify that we don't have an selected option anymore
// Verify that we don't have a selected option anymore
assertNotActiveComboboxOption(options[1])

// Verify that we saw the `null` change coming in
Expand Down Expand Up @@ -5324,10 +5324,10 @@ describe.each([{ virtual: true }, { virtual: false }])('Mouse interactions %s',
)
}

// Render a uncontrolled combobox
// Render an uncontrolled combobox
render(<Example />)

// Change to an controlled combobox
// Change to a controlled combobox
await click(getByText('to controlled'))

// Make sure we get a warning
Expand All @@ -5339,7 +5339,7 @@ describe.each([{ virtual: true }, { virtual: false }])('Mouse interactions %s',
// Render a fresh uncontrolled combobox
render(<Example />)

// Change to an controlled combobox
// Change to a controlled combobox
await click(getByText('to controlled'))

// We shouldn't have gotten another warning as we do not want to warn on every render
Expand Down
2 changes: 1 addition & 1 deletion packages/@headlessui-react/src/components/switch/switch.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,7 @@ describe('Form compatibility', () => {
expect(submits).toHaveBeenLastCalledWith([['notifications', 'on']])
})

it('should be possible to submit a form with an boolean value', async () => {
it('should be possible to submit a form with a boolean value', async () => {
let submits = jest.fn()

function Example() {
Expand Down
2 changes: 1 addition & 1 deletion packages/@headlessui-react/src/utils/form.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ it.each([
['name[nickname][preferred]', 'JDoe'],
],
],
])('should encode an input of %j to an form data output', (input, output) => {
])('should encode an input of %j to a form data output', (input, output) => {
expect(objectToFormEntries(input)).toEqual(output)
})
2 changes: 1 addition & 1 deletion packages/@headlessui-vue/src/components/combobox/combobox.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4352,7 +4352,7 @@ describe.each([{ virtual: false }, { virtual: false }])(
await press(Keys.Backspace)
expect(getComboboxInput()?.value).toBe('')

// Verify that we don't have an selected option anymore since we are in `nullable` mode
// Verify that we don't have a selected option anymore since we are in `nullable` mode
assertNotActiveComboboxOption(options[1])
assertNoSelectedComboboxOption()

Expand Down
2 changes: 1 addition & 1 deletion packages/@headlessui-vue/src/components/switch/switch.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,7 @@ describe('Form compatibility', () => {
expect(submits).toHaveBeenLastCalledWith([['notifications', 'on']])
})

it('should be possible to submit a form with an boolean value', async () => {
it('should be possible to submit a form with a boolean value', async () => {
let submits = jest.fn()

renderTemplate({
Expand Down
2 changes: 1 addition & 1 deletion packages/@headlessui-vue/src/utils/form.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ it.each([
['name[nickname][preferred]', 'JDoe'],
],
],
])('should encode an input of %j to an form data output', (input, output) => {
])('should encode an input of %j to a form data output', (input, output) => {
expect(objectToFormEntries(input)).toEqual(output)
})