Fix Checkbox labels inside Field#3878
Open
cyphercodes wants to merge 1 commit into
Open
Conversation
|
@cyphercodes is attempting to deploy a commit to the Tailwind Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3876.
Summary
Label's renderedforattribute when the resolved target is not a labelable HTML element, avoiding Chrome's warning forField+Label+Checkbox.foris not rendered.roleattribute when forwarding label clicks to ARIA checkbox/radio/switch controls.forattribute is rendered, label clicks still toggle/focus the checkbox, and form data is preserved.Test plan
CI=true npm run react test checkbox labelnpx tsc -p packages/@headlessui-react/tsconfig.json --noEmit --pretty falsenpx prettier --check packages/@headlessui-react/src/components/label/label.tsx packages/@headlessui-react/src/components/checkbox/checkbox.test.tsx packages/@headlessui-react/src/utils/dom.ts