Simplify document class list detection#1529
Open
thecrypticace wants to merge 17 commits into
Open
Conversation
We replace `findClassNamesInRange` with a two step process we use elsewhere: 1. find all class lists in the document; 2. find classes in each class list
Instead of dropping down to the individual “range” helpers we should test things at the document level since everything should go through those
This was already the case because the class attribute matching was slicing on text with comments already removed.
This simplifies some of the code making it more linearly scannable
This guarantees class hovers work identically to things like color decorators that already use whole document class lists
Document boundaries are handled at a level above this now so we can guarantee that this will only be called for individual document parts — including JSX. Because of this we can simplify how we do class function matching.
This makes the code a bit more linear. Using `.split(…)` is still optimal for performance in V8 and JSC when splitting larger class lists. This also refactors the code a bit for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be mostly functionally equivalent. It simplifies a good chunk of the code used throughout to find class lists and class names.
getConfiguration(…)which would increase based on the number of embedded languages in the document. These hit a cache anyway so the overhead wasn't significant but the repeated calls aren't necessary.