Merged
Conversation
Contributor
Author
|
We're still running some CI stuff on Node 14. I think we can probably drop those. What do you think @RobinMalfait? Like I don't see any reason do run Node CI on anything < Node 20 really. |
thecrypticace
force-pushed
the
release/3.4.18
branch
from
ca23802 to
6b49e26
Compare
Member
|
That seems fine, I think we can run CI on the latest LTS and newer. Only thing we have to make sure is that if we build/publish with an older node version that the generated files don't change when changing it to a newer version. If the artifacts did change, then maybe we bump to the Node 18 or LTS? |
RobinMalfait
approved these changes
Oct 1, 2025
Contributor
Author
|
Okay, I'll set that up after we do the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.