Skip to content

Use non-existing example in tests#20021

Merged
RobinMalfait merged 1 commit into
mainfrom
feat/use-non-existing-example
May 7, 2026
Merged

Use non-existing example in tests#20021
RobinMalfait merged 1 commit into
mainfrom
feat/use-non-existing-example

Conversation

@RobinMalfait
Copy link
Copy Markdown
Member

This PR makes a small change to the tests. In some cases, where we test @utility functionality we use tab-* utilities.

But there is a possibility that we will add this as an actual utility, so instead let's use a much more generic example-* utility. Then we can read from the --example theme value, and use --resolved-value: …; and --resolved-modifier: …; values.

It's admittedly more vague, but chances of conflicts go way down. Until CSS or Tailwind CSS introduces an example-* utility...

Test plan

  1. Only tests changed, and all of them still pass

@RobinMalfait RobinMalfait requested a review from a team as a code owner May 7, 2026 11:16
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 7, 2026

Confidence Score: 5/5

All changes are confined to test files and are a straight find-and-replace of fixtures; no production code is touched.

Every edit is a mechanical rename of test-only identifiers (tab-*example-*, tab-size--resolved-value, theme key renames). The inline snapshots were updated to match, and the one observable output difference (calc expression preserved unevaluated in a custom property vs. a real CSS property) is correct CSS behaviour. No logic, API, or production code changed.

No files require special attention.

Reviews (1): Last reviewed commit: "use non-existing example" | Re-trigger Greptile

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b1f2fa03-d2ec-46a1-97a0-fe1b15630620

📥 Commits

Reviewing files that changed from the base of the PR and between 12eb5ae and b777e7e.

📒 Files selected for processing (3)
  • packages/tailwindcss/src/canonicalize-candidates.test.ts
  • packages/tailwindcss/src/intellisense.test.ts
  • packages/tailwindcss/src/utilities.test.ts

Walkthrough

This pull request updates test coverage across three test files for Tailwind CSS functional utilities. The changes systematically replace tab-* fixture utilities with a new example-* utility pattern, refactoring test assertions and snapshots to validate value resolution behavior. Tests are expanded to cover theme variable globbing (--example-* and escaped variants), bare named value canonicalization, arbitrary value syntax, literal values, unsupported data type handling, complex computed expressions with calc, modifier/value pairs, negative utility computation, and default fallback mechanisms. All changes are test-only with no alterations to exported/public entities.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: replacing test fixtures from tab-* to a non-conflicting example-* utility.
Description check ✅ Passed The description clearly explains why the change was made (avoid conflicts with potential real utilities) and the test plan confirms all tests pass.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@RobinMalfait RobinMalfait merged commit 754e751 into main May 7, 2026
9 checks passed
@RobinMalfait RobinMalfait deleted the feat/use-non-existing-example branch May 7, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant