-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fix shadow replacer for all <length> types
#20067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isLengthmisclassifies color functions containing math calls as lengthsisLengthdelegates tohasMathFn, which returnstruefor any string that contains a math function call — not only strings that are a math function. Becausesegmentis paren-aware, a color likeoklch(calc(50%) 0.1 90deg)arrives as a single token;hasMathFnsees the embeddedcalc(and returnstrue, soisLengthreturnstrue. With both offsets already filled, the part falls through the length branch silently,colorstaysnull, and the output appendscurrentcolorinstead of wrapping the actual color.replaceShadowColors('0 0 0 oklch(calc(50%) 0.1 90deg)', replacer)would produce0 0 0 oklch(calc(50%) 0.1 90deg) var(--tw-shadow-color, currentcolor)rather than the expected0 0 0 var(--tw-shadow-color, oklch(calc(50%) 0.1 90deg)).The original
LENGTHregex required values to start with a digit, so color function names (which start with letters) could never match. The fix needs to ensure that math-function detection only fires when the math function is at the start of the token, not embedded inside another function.