check input list is 'all master' or 'all slave', can't be mix

Author: vinllen

src/full_check/client/address.go

@@ -33,23 +33,52 @@ func HandleAddress(address, password, authType string) ([]string, error) {
 			role = RoleMaster
 		}
 
-		// create client to fetch
-		client, err := NewRedisClient(RedisHost{
-			Addr:     []string{clusterList[0]},
-			Password: password,
-			Authtype: authType,
-		}, 0)
+		return fetchNodeList(clusterList[0], password, authType, role)
+	} else {
+		clusterList := strings.Split(address, AddressClusterSplitter)
+		if len(clusterList) <= 1 {
+			return clusterList, nil
+		}
+
+		// fetch master
+		masterList, err := fetchNodeList(clusterList[0], password, authType, common.TypeMaster)
 		if err != nil {
-			return nil, fmt.Errorf("fetch cluster info failed[%v]", err)
+			return nil, err
+		}
+		// compare master list equal
+		if common.CompareUnorderedList(masterList, clusterList) {
+			return clusterList, nil
 		}
 
-		if addressList, err := common.GetAllClusterNode(client.conn, role, "address"); err != nil {
-			return nil, fmt.Errorf("fetch cluster node failed[%v]", err)
-		} else {
-			return addressList, nil
+		slaveList, err := fetchNodeList(clusterList[0], password, authType, common.TypeSlave)
+		if err != nil {
+			return nil, err
+		}
+		// compare slave list equal
+		if common.CompareUnorderedList(slaveList, clusterList) {
+			return clusterList, nil
 		}
+
+		return nil, fmt.Errorf("if type isn't cluster, should only used 1 node. if type is cluster, " +
+			"input list should be all master or all slave: 'master1;master2;master3...' or " +
+			"'slave1;slave2;slave3...'")
+	}
+}
+
+func fetchNodeList(oneNode, password, authType, role string) ([]string, error) {
+	// create client to fetch
+	client, err := NewRedisClient(RedisHost{
+		Addr:     []string{oneNode},
+		Password: password,
+		Authtype: authType,
+	}, 0)
+	if err != nil {
+		return nil, fmt.Errorf("fetch cluster info failed[%v]", err)
+	}
+
+	if addressList, err := common.GetAllClusterNode(client.conn, role, "address"); err != nil {
+		return nil, fmt.Errorf("fetch cluster node failed[%v]", err)
 	} else {
-		clusterList := strings.Split(address, AddressClusterSplitter)
-		return clusterList, nil
+		return addressList, nil
 	}
-}
+}

src/full_check/common/command.go

@@ -129,4 +129,29 @@ func GetAllClusterNode(client redigo.Conn, role string, choose string) ([]string
 	}
 
 	return result, nil
+}
+
+// compare two unordered list. return true means equal.
+func CompareUnorderedList(a, b []string) bool {
+	if len(a) != len(b) {
+		return false
+	}
+
+	if len(a) == 0 {
+		return true
+	}
+
+	setA := map[string]struct{}{}
+
+	for _, x := range a {
+		setA[x] = struct{}{}
+	}
+
+	for _, x := range b {
+		if _, ok := setA[x]; !ok {
+			return false
+		}
+	}
+
+	return true
 }

src/full_check/main.go

@@ -101,14 +101,18 @@ func main() {
 	}
 
 	sourceAddressList, err := client.HandleAddress(conf.Opts.SourceAddr, conf.Opts.SourcePassword, conf.Opts.SourceAuthType)
-	if len(sourceAddressList) > 1 && conf.Opts.SourceDBType != 1 {
+	if err != nil {
+		panic(common.Logger.Errorf("source address[%v] illegal[%v]", conf.Opts.SourceAddr, err))
+	} else if len(sourceAddressList) > 1 && conf.Opts.SourceDBType != 1 {
 		panic(common.Logger.Errorf("looks like the source is cluster? please set sourcedbtype"))
 	} else if len(sourceAddressList) == 0 {
 		panic(common.Logger.Errorf("input source address is empty"))
 	}
 
 	targetAddressList, err := client.HandleAddress(conf.Opts.TargetAddr, conf.Opts.TargetPassword, conf.Opts.TargetAuthType)
-	if len(targetAddressList) > 1 && conf.Opts.TargetDBType != 1 {
+	if err != nil {
+		panic(common.Logger.Errorf("target address[%v] illegal[%v]", conf.Opts.TargetAddr, err))
+	} else if len(targetAddressList) > 1 && conf.Opts.TargetDBType != 1 {
 		panic(common.Logger.Errorf("looks like the target is cluster? please set targetdbtype"))
 	} else if len(targetAddressList) == 0 {
 		panic(common.Logger.Errorf("input target address is empty"))