Skip to content

Commit a4e1937

Browse files
suxb201claude
andcommitted
fix: remove arbitrary 128 argument limit when parsing AOF files
Redis does not have a hard limit on command arguments, but RedisShake was limiting AOF command arguments to 128. This restriction prevented parsing AOF files with large batch operations (MSET, SADD, LPUSH, etc.). Remove the SizeMax limit entirely to match Redis behavior. Fixes #1024 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 47d42ae commit a4e1937

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

internal/aof/aof.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ const (
1919
Empty = 2
2020
Failed = 4
2121
Truncated = 5
22-
SizeMax = 128
2322
)
2423

2524
type Loader struct {
@@ -126,9 +125,6 @@ func (ld *Loader) LoadSingleAppendOnlyFile(ctx context.Context, timestamp int64)
126125
if argc < 1 {
127126
log.Panicf("Bad File format reading the append only File %v:make a backup of your AOF File, then use ./redis-check-AOF --fix <FileName.manifest>", filePath)
128127
}
129-
if argc > int64(SizeMax) {
130-
log.Panicf("Bad File format reading the append only File %v:make a backup of your AOF File, then use ./redis-check-AOF --fix <FileName.manifest>", filePath)
131-
}
132128
e := entry.NewEntry()
133129
var argv []string
134130

0 commit comments

Comments
 (0)