Fix wasm ssh in nix build#588
Open
SuperSandro2000 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — align the Nix build with the Docker/local build layout for Browser SSH WASM assets and drop the obsolete source-path rewrite.
- Move WASM assets to
public/innix/package.nix— matchesbuild.sh,Dockerfile,.gitignore, and the React Router public-asset convention that serves/hp_ssh.wasmand/wasm_exec.jsfrom the app root. - Switch
pnpm react-router buildtopnpm build—package.jsonmapsbuildtoreact-router build, so this is equivalent and keeps the Nix expression consistent with the documented local build. - Remove the
$PWD -> ../..sedrewrite — the leftover path substitution is tied to earlier bundled-build layouts and is unnecessary now that the build relies on public-directory assets instead of source-relative paths.
Kimi K2 (free via Pullfrog for OSS) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

That are the wasm ssh bits from NixOS/nixpkgs#538802