Skip to content

Fix wasm ssh in nix build#588

Open
SuperSandro2000 wants to merge 1 commit into
tale:mainfrom
SuperSandro2000:patch-2
Open

Fix wasm ssh in nix build#588
SuperSandro2000 wants to merge 1 commit into
tale:mainfrom
SuperSandro2000:patch-2

Conversation

@SuperSandro2000

Copy link
Copy Markdown

That are the wasm ssh bits from NixOS/nixpkgs#538802

@SuperSandro2000 SuperSandro2000 requested a review from tale as a code owner July 7, 2026 22:05

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — align the Nix build with the Docker/local build layout for Browser SSH WASM assets and drop the obsolete source-path rewrite.

  • Move WASM assets to public/ in nix/package.nix — matches build.sh, Dockerfile, .gitignore, and the React Router public-asset convention that serves /hp_ssh.wasm and /wasm_exec.js from the app root.
  • Switch pnpm react-router build to pnpm buildpackage.json maps build to react-router build, so this is equivalent and keeps the Nix expression consistent with the documented local build.
  • Remove the $PWD -> ../.. sed rewrite — the leftover path substitution is tied to earlier bundled-build layouts and is unnecessary now that the build relies on public-directory assets instead of source-relative paths.

Pullfrog  | View workflow run | Using Kimi K2 (free via Pullfrog for OSS) | 𝕏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant